feat(web): select top dataset when suggest was triggered manually #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When use clicks "Suggest" button on main page, if suggestion run completes successfully, then top matching dataset is selected as current dataset automatically. This does not happen after implicit suggestion runs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Let's focus on the `getPromise()` calls followed by the `set(datasetCurrentAtom, ...)` call. This combo lags behind and does not yet receive the suggestion results we've just `set()` in the `onResult()` callback. With this config the "Suggest" button needs to be clicked twice for autoselection to take effect. And with current (quite complex) code organization I don't see any more obvious way to set the top dataset. Let's use an additional boolean state which tells that the suggestion was triggered manually. We can then use it in the caller component, which would set. This guarantees ordering of operations and correct selection of the top dataset. Technically, this boolean flag does not need to be retained. I hope it does not cause unwanted side effects across runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes behavior of dataset suggestions: now when use clicks "Suggest" button on main page, if suggestion run completes successfully, then top matching dataset is selected as current dataset automatically. This does not happen after automatic suggestion runs.