fix(web): update current dataset when remote pathogen.json changes #1453
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1450 This removes dataset path equality check preventing dataset object from being updated. The older dataset object version from local storage will then be used. I don't remember why this check was needed. It seems overwriting current dataset is fine whether it's equal (by path or before paths were a thing using name/ref/tag). Hopefully this does not bring any undesired effects. I consider this a short-term fix. A proper solution should probably remove storing dataset object in the local storage, but only storing a dataset identifier there. But ti's more involved and we need to figure out what generally identifies a dataset (dataset path, alright, but we can also have the same path on different dataset servers as well as single datasets not belonging to any server).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1450
This removes dataset path equality check preventing dataset object from being updated. The older dataset object version from local storage will then be used.
I don't remember why this check was needed. It seems overwriting current dataset is fine whether it's equal (by path or before paths were a thing using name/ref/tag). Hopefully this does not bring any undesired effects.
I consider this a short-term fix. A proper solution should probably remove storing dataset object in the local storage, but only storing a dataset identifier there. But ti's more involved and we need to figure out what generally identifies a dataset (dataset path, alright, but we can also have the same path on different dataset servers as well as single datasets not belonging to any server).