Make data download URLs default-branch-name agnostic [#6] #7
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for renaming the default branch from `master` to `main`, and provides some insulation against any future default branch name changes, should that ever happen.
j23414
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Ohh, I didn't know the @ feature. Looks good to me:
nextflow run nextstrain/zika-tutorial-nextflow \
-r rename-master-to-main-6 \
-profile docker
N E X T F L O W ~ version 23.04.4
Launching `https://github.com/nextstrain/zika-tutorial-nextflow` [extravagant_archimedes] DSL2 - revision: eb89ed0514 [rename-master-to-main-6]
WARN: Access to undefined parameter `help` -- Initialise it to a default value eg. `params.help = some_value`
executor > local (10)
[92/d4f72f] process > fetch_zika_tutorial [100%] 1 of 1 ✔
[8c/2def5a] process > index (1) [100%] 1 of 1 ✔
[6d/a95f37] process > filter (1) [100%] 1 of 1 ✔
[27/6de525] process > align (1) [100%] 1 of 1 ✔
[40/066c9e] process > tree (1) [100%] 1 of 1 ✔
[1e/eda5a1] process > refine (1) [100%] 1 of 1 ✔
[3b/b4e0a9] process > ancestral (1) [100%] 1 of 1 ✔
[14/13ac15] process > translate (1) [100%] 1 of 1 ✔
[e7/587524] process > traits (1) [100%] 1 of 1 ✔
[e2/16afbf] process > export (1) [100%] 1 of 1 ✔
nextstrain view results
joverlee521
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Swap
masterin data download URLs for@.This is in preparation for renaming the default branch from
mastertomain, and provides some insulation against any future default branch name changes, should that ever happen.Related issue(s)
#6
nextstrain/private#118
Checklist