Refactor #6
Refactor #6
Conversation
npm run build works now without global install
I don't know why I do this to myself. But it's done now. https://github.com/OneSignal/OneSignal-Website-SDK Yoinked the configs from here
I just want these for the typechecks
And run on test files
edmundmiller
force-pushed
the
refactor
branch
from
344d109 to
56837a0
Compare
Doesn't work yet though
edmundmiller
force-pushed
the
refactor
branch
from
b8da5c7 to
0f7b19a
Compare
edmundmiller
force-pushed
the
refactor
branch
from
0f7b19a to
814348c
Compare
|
Nice! Thanks. This action has needed some love for a while but has been low on my priority list. It will take me a couple days before I can get through this, but it looks good on initial pass. |
There was a problem hiding this comment.
It seems like the publish workflow should only run when tests pass? You can make one depend on the other so they don't run in parallel. Or maybe I'm misinterpreting your intentions.
I'm also wondering, does your code need to be async?
Since you're using TypeScript, I would define an interface for the parts of the release and asset objects that you intend to use. Or maybe there is a defined type for them already and you just need to use it?
| @@ -17,7 +17,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: MillironX/setup-nextflow@v1 | |||
| - uses: nf-core/setup-nextflow@v1.2.0 | |||
There was a problem hiding this comment.
Seems like the nextflow-io org would actually be the ideal home for this action?
There was a problem hiding this comment.
Agreed, not my department though! @ewels
Co-authored-by: ewels <[email protected]>
edmundmiller
force-pushed
the
refactor
branch
from
beafc6d to
2138b34
Compare
| test('lastest_stable_release_data', async t => { | ||
| const result = await functions.latest_stable_release_data(t.context.octokit) | ||
| t.is(typeof result, 'object') | ||
| t.is(result.tag_name, 'v22.10.2') |
There was a problem hiding this comment.
Is this going to throw errors when a new stable Nextflow version is released?
There was a problem hiding this comment.
Yeah, I meant to turn these into a mock, I just didn't know what I was even mocking at the beginning 😆 I'll get that sorted.
It's definitely going to throw an error when a new version gets released. I think a note about it is fine.
Adds some things, IDK if they're worthy of the CHANGELOG because it doesn't actually effect the end user.
I just tried to keep things 1 to 1 identical with what was in the previous version and make it easier for others to work on the code base and pick it up when needed.