Refactor

.eslintignore

@@ -0,0 +1,3 @@
+dist/
+lib/
+node_modules/

.eslintrc.json

@@ -0,0 +1,63 @@
+{
+  "plugins": ["ava", "@typescript-eslint", "simple-import-sort"],
+  "extends": ["plugin:github/recommended", "plugin:ava/recommended"],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "ecmaVersion": 9,
+    "sourceType": "module",
+    "project": "./tsconfig.json"
+  },
+  "rules": {
+    "simple-import-sort/imports": "error",
+    "simple-import-sort/exports": "error",
+    "i18n-text/no-en": "off",
+    "eslint-comments/no-use": "off",
+    "import/no-namespace": "off",
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": "error",
+    "@typescript-eslint/explicit-member-accessibility": [
+      "error",
+      { "accessibility": "no-public" }
+    ],
+    "@typescript-eslint/no-require-imports": "error",
+    "@typescript-eslint/array-type": "error",
+    "@typescript-eslint/await-thenable": "error",
+    "@typescript-eslint/ban-ts-comment": "error",
+    "camelcase": "off",
+    "@typescript-eslint/consistent-type-assertions": "error",
+    "@typescript-eslint/explicit-function-return-type": [
+      "error",
+      { "allowExpressions": true }
+    ],
+    "@typescript-eslint/func-call-spacing": ["error", "never"],
+    "@typescript-eslint/no-array-constructor": "error",
+    "@typescript-eslint/no-empty-interface": "error",
+    "@typescript-eslint/no-explicit-any": "error",
+    "@typescript-eslint/no-extraneous-class": "error",
+    "@typescript-eslint/no-for-in-array": "error",
+    "@typescript-eslint/no-inferrable-types": "error",
+    "@typescript-eslint/no-misused-new": "error",
+    "@typescript-eslint/no-namespace": "error",
+    "@typescript-eslint/no-non-null-assertion": "warn",
+    "@typescript-eslint/no-unnecessary-qualifier": "error",
+    "@typescript-eslint/no-unnecessary-type-assertion": "error",
+    "@typescript-eslint/no-useless-constructor": "error",
+    "@typescript-eslint/no-var-requires": "error",
+    "@typescript-eslint/prefer-for-of": "warn",
+    "@typescript-eslint/prefer-function-type": "warn",
+    "@typescript-eslint/prefer-includes": "error",
+    "@typescript-eslint/prefer-string-starts-ends-with": "error",
+    "@typescript-eslint/promise-function-async": "error",
+    "@typescript-eslint/require-array-sort-compare": "error",
+    "@typescript-eslint/restrict-plus-operands": "error",
+    "semi": "off",
+    "sort-imports": "off",
+    "@typescript-eslint/semi": ["error", "never"],
+    "@typescript-eslint/type-annotation-spacing": "error",
+    "@typescript-eslint/unbound-method": "error"
+  },
+  "env": {
+    "node": true,
+    "es6": true
+  }
+}

.gitattributes

@@ -0,0 +1 @@
+dist/** -diff linguist-generated=true

.github/workflows/example.yml

@@ -2,8 +2,12 @@ name: Example builds
 
 on:
   push:
+    branches:
+      - master
   pull_request:
   workflow_dispatch:
+  release:
+    types: [published]
 
 jobs:
   test:
@@ -13,13 +17,13 @@ jobs:
       fail-fast: false
       matrix:
         nextflow_version:
-          - "21.10.3"
-          - "22.04"
-          - "22.03.1-edge"
-          - "latest"
-          - "latest-stable"
-          - "latest-edge"
-          - "latest-everything"
+          - '21.10.3'
+          - '22.04'
+          - '22.03.1-edge'
+          - 'latest'
+          - 'latest-stable'
+          - 'latest-edge'
+          - 'latest-everything'
         all_distribution:
           - true
           - false
@@ -29,9 +33,10 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: 16
-          cache: "npm"
-      - run: npm i -g @vercel/ncc
-      - run: npm ci && npm run build
+          cache: 'npm'
+      - run: npm ci
+      - run: npm run build
+      - run: npm run package
       - uses: ./
         with:
           version: ${{ matrix.nextflow_version }}

.github/workflows/publish.yml

@@ -12,9 +12,10 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: 16
-          cache: "npm"
-      - run: npm i -g @vercel/ncc
-      - run: npm ci && npm run build
+          cache: 'npm'
+      - run: npm ci
+      - run: npm run build
+      - run: npm run package
       - uses: JasonEtco/build-and-tag-action@v1
         env:
           GITHUB_TOKEN: ${{ github.token }}

.github/workflows/test.yml

@@ -0,0 +1,27 @@
+name: Run tests
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+  workflow_dispatch:
+  release:
+    types: [published]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16
+          cache: 'npm'
+      - run: npm ci
+      - run: npm run build
+      - run: npm run format:check
+      - run: npm run lint
+      - run: npm run package
+      # FIXME Token doesn't get passed correctly
+      # - run: npm run test

.gitignore

@@ -128,3 +128,7 @@ dist
 .yarn/build-state.yml
 .yarn/install-state.gz
 .pnp.*
+
+# Ignore built ts files
+__tests__/runner/*
+lib/**/*

.prettierignore

@@ -0,0 +1,3 @@
+dist/
+lib/
+node_modules/

.prettierrc.json

@@ -0,0 +1,10 @@
+{
+  "printWidth": 80,
+  "tabWidth": 2,
+  "useTabs": false,
+  "semi": false,
+  "singleQuote": true,
+  "trailingComma": "none",
+  "bracketSpacing": true,
+  "arrowParens": "avoid"
+}

CHANGELOG.md

@@ -37,8 +37,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - GitHub Actions workflow to test Nextflow installation and downstream usage
 - Documentation and license files
 
-[unreleased]: https://github.com/MillironX/setup-nextflow/compare/v1.2.0...HEAD
-[1.2.0]: https://github.com/MillironX/setup-nextflow/compare/v1.1.1...v1.2.0
-[1.1.0]: https://github.com/MillironX/setup-nextflow/compare/v1.0.1...v1.1.0
-[1.0.1]: https://github.com/MillironX/setup-nextflow/compare/v1.0.0...v1.0.1
-[1.0.0]: https://github.com/MillironX/setup-nextflow/releases/tag/v1.0.0
+[unreleased]: https://github.com/nf-core/setup-nextflow/compare/v1.2.0...HEAD
+[1.2.0]: https://github.com/nf-core/setup-nextflow/compare/v1.1.1...v1.2.0
+[1.1.0]: https://github.com/nf-core/setup-nextflow/compare/v1.0.1...v1.1.0
+[1.0.1]: https://github.com/nf-core/setup-nextflow/compare/v1.0.0...v1.0.1
+[1.0.0]: https://github.com/nf-core/setup-nextflow/releases/tag/v1.0.0

LICENSE

@@ -1,7 +1,21 @@
-Copyright 2022 Thomas A. Christensen II
+MIT License
 
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+Copyright (c) 2022 nf-core
 
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

README.md

@@ -1,8 +1,8 @@
 # Setup Nextflow for GitHub Actions
 
-[![Testing](https://github.com/MillironX/setup-nextflow/actions/workflows/example.yml/badge.svg)](https://github.com/MillironX/setup-nextflow/actions/workflows/example.yml)
-[![MIT License](https://img.shields.io/github/license/MillironX/setup-nextflow?logo=opensourceinitiative)](https://github.com/MillironX/setup-nextflow/blob/master/LICENSE)
-[![GitHub tag (latest by date)](https://img.shields.io/github/v/tag/MillironX/setup-nextflow?logo=github)](https://github.com/MillironX/setup-nextflow/releases/latest)
+[![Testing](https://github.com/nf-core/setup-nextflow/actions/workflows/example.yml/badge.svg)](https://github.com/nf-core/setup-nextflow/actions/workflows/example.yml)
+[![MIT License](https://img.shields.io/github/license/nf-core/setup-nextflow?logo=opensourceinitiative)](https://github.com/nf-core/setup-nextflow/blob/master/LICENSE)
+[![GitHub tag (latest by date)](https://img.shields.io/github/v/tag/nf-core/setup-nextflow?logo=github)](https://github.com/nf-core/setup-nextflow/releases/latest)
 [![Get from GitHub Actions](https://img.shields.io/static/v1?label=actions&message=marketplace&color=green&logo=githubactions)](https://github.com/marketplace/actions/setup-nextflow)
 
 An action to install [Nextflow](https://nextflow.io) into a GitHub Actions workflow and make it available for subsequent steps.
@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: MillironX/setup-nextflow@v1
+      - uses: nf-core/setup-nextflow@v1.2.0
       - run: nextflow run ${GITHUB_WORKSPACE}
 ```
 
@@ -73,3 +73,20 @@ This action locates the releases based upon the GitHub API, and requires an acce
 ## Outputs
 
 There are no outputs from this action.
+
+## Why was this action made?
+
+[Slack link](https://nfcore.slack.com/archives/CE56GDKN0/p1655210460795839)
+
+You may be asking, why not just a few yaml lines?
+
+```yaml
+- name: Install Nextflow
+  env:
+    NXF_VER: ${{ matrix.NXF_VER }}
+  run: |
+    wget -qO- get.nextflow.io | bash
+    sudo mv nextflow /usr/local/bin/
+```
+
+The versioning. From the Nextflow install script you can't get `latest-edge` or `latest-everything` for example.

action.yml

@@ -1,22 +1,22 @@
-name: "Setup Nextflow"
-description: "Install Nextflow and add it to the PATH"
-author: "Thomas A. Christensen II"
+name: 'Setup Nextflow'
+description: 'Install Nextflow and add it to the PATH'
+author: 'nf-core'
 inputs:
   version:
-    description: "The Nextflow version to download (if necessary) and use. Example: 21.10.3"
+    description: 'The Nextflow version to download (if necessary) and use. Example: 21.10.3'
     required: false
-    default: "latest-stable"
+    default: 'latest-stable'
   all:
     description: "Whether to install every Nextflow release via the '-all' distribution."
     required: false
     default: false
   token:
-    description: "GitHub token to access the GitHub Releases API. The default token should be sufficient for all use cases."
+    description: 'GitHub token to access the GitHub Releases API. The default token should be sufficient for all use cases.'
     required: false
     default: ${{ github.token }}
 runs:
-  using: "node16"
-  main: "dist/index.js"
+  using: 'node16'
+  main: 'dist/index.js'
 branding:
-  icon: "shuffle"
-  color: "green"
+  icon: 'shuffle'
+  color: 'green'