Fix #208 and #209 #210
Merged
Fix #208 and #209 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 17, 2024
|
Thanks!! This worked great - approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated to
get_/set_annotationsin #202, we had to handle converting the result to an R list ourselves since that is no longer returned automatically as withgetAnnotations. This wasn't clearly realized since there was a missing test that would have revealed this. For now, I updatedcopy_annotationsto handle downstream usage inderive_annotationsthat was affected.Reran the non-working code in #209 (comment) and manifests were generated (thanks for the clear doc in issue and checking different versions).
Update: should no longer need to manually modify sample names with
o$Strelka2 <- o$Strelka2 %>% dplyr::mutate(sample = stringr::str_remove(sample, "_vs_.+"))