Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block sending Messages to Identities which are in deletion or for which the Relationship is terminated #286

Merged
merged 114 commits into from
Dec 3, 2024
Merged

Block sending Messages to Identities which are in deletion or for which the Relationship is terminated #286

merged 114 commits into from
Dec 3, 2024

Conversation

RuthDiG
Copy link
Contributor

@RuthDiG RuthDiG commented Sep 30, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@RuthDiG RuthDiG added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Sep 30, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.76023% with 50 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ime/src/useCases/transport/messages/SendMessage.ts 71.01% 20 Missing ⚠️
...ransport/src/modules/messages/MessageController.ts 71.42% 12 Missing ⚠️
...es/requests/outgoing/OutgoingRequestsController.ts 38.46% 8 Missing ⚠️
...es/requests/incoming/IncomingRequestsController.ts 69.23% 4 Missing ⚠️
packages/transport/src/core/TransportCoreErrors.ts 66.66% 4 Missing ⚠️
...nsumption/src/consumption/ConsumptionCoreErrors.ts 75.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
...kages/runtime/src/useCases/common/RuntimeErrors.ts 80.98% <100.00%> (+0.98%) ⬆️
...nsumption/src/consumption/ConsumptionCoreErrors.ts 80.48% <75.00%> (-0.13%) ⬇️
...es/requests/incoming/IncomingRequestsController.ts 95.85% <69.23%> (-0.79%) ⬇️
packages/transport/src/core/TransportCoreErrors.ts 60.00% <66.66%> (-0.45%) ⬇️
...es/requests/outgoing/OutgoingRequestsController.ts 82.11% <38.46%> (-1.39%) ⬇️
...ransport/src/modules/messages/MessageController.ts 87.81% <71.42%> (+0.04%) ⬆️
...ime/src/useCases/transport/messages/SendMessage.ts 75.14% <71.01%> (+6.39%) ⬆️

... and 2 files with indirect coverage changes

@RuthDiG RuthDiG marked this pull request as ready for review October 4, 2024 08:44
@RuthDiG RuthDiG removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 4, 2024
Magnus-Kuhn
Magnus-Kuhn reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some consumption tests

@RuthDiG RuthDiG added the wip Work in Progress (blocks mergify from auto update the branch) label Oct 8, 2024
@jkoenig134
Copy link
Member

@RuthDiG could you please use full words instead of the abbreviation in the PR title? (resp.)

@RuthDiG RuthDiG changed the title Add validation to block sending or responding messages to resp. from an Identity with an active IdentityDeletionProcess Add validation to block sending or responding messages to respective from an Identity with an active IdentityDeletionProcess Oct 8, 2024
@jkoenig134
Copy link
Member

I had a hard time processing your PR title. What do you think about Block sending messages to identities which are in deletion?

jkoenig134
jkoenig134 previously requested changes Oct 9, 2024
View reviewed changes
@RuthDiG
Copy link
Contributor Author

RuthDiG commented Oct 9, 2024

I had a hard time processing your PR title. What do you think about Block sending messages to identities which are in deletion?

I can do so but perhaps it would be better Block sending Messages to peer with Relationship blockade to integrate also the case when the Relationship is terminated?

@jkoenig134
Copy link
Member

Then you completely leave out the identity deletion. Maybe you find a title that includes both.

@RuthDiG RuthDiG changed the title Add validation to block sending or responding messages to respective from an Identity with an active IdentityDeletionProcess Block sending messages to identities which are in deletion or whose relationship is terminated. Oct 9, 2024
@britsta britsta marked this pull request as ready for review November 22, 2024 12:44
@britsta britsta marked this pull request as draft November 22, 2024 12:45
@britsta britsta marked this pull request as ready for review December 3, 2024 12:51
jkoenig134
jkoenig134 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@britsta britsta merged commit 20398db into main Dec 3, 2024
19 checks passed
@britsta britsta deleted the feature/block-sending-messages-to-a-deleted-or-toBeDeleted-Identity branch December 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis left review comments

@Magnus-Kuhn Magnus-Kuhn Magnus-Kuhn left review comments

@britsta britsta britsta left review comments

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@slavistan slavistan Awaiting requested review from slavistan

@sebbi08 sebbi08 Awaiting requested review from sebbi08

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RuthDiG @jkoenig134 @Milena-Czierlinski @britsta @tnotheis @Magnus-Kuhn