Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block sending Messages to Identities which are in deletion or for which the Relationship is terminated #286

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
0d7ce00
feat: add validation to incoming- outgoing and messageController
RuthDiG Sep 30, 2024
260ed3a
fix: relationships.test
RuthDiG Sep 30, 2024
46ee595
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
RuthDiG Oct 2, 2024
f851a03
fix: Notification shouldn't be blocked by the Runtime
RuthDiG Oct 2, 2024
fb898bc
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
RuthDiG Oct 4, 2024
d32e641
fix: change place of validation
RuthDiG Oct 4, 2024
5fa3236
refactor: incorporate code review
RuthDiG Oct 4, 2024
18c1d14
feat: provide list of failing addresses and other changes
RuthDiG Oct 7, 2024
eb63a7e
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 7, 2024
31c5a93
fix: add validation regarding RelationshipTermination
RuthDiG Oct 8, 2024
1bfb159
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
RuthDiG Oct 10, 2024
d0ee5bf
fix: refactoring of MessageController etc.
RuthDiG Oct 10, 2024
c6c03c7
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
RuthDiG Oct 11, 2024
86ca341
feat: make error more explicitly
RuthDiG Oct 11, 2024
1f3f5df
chore: test without enabling modules
RuthDiG Oct 11, 2024
85cf655
fix: add validation in case of Request
RuthDiG Oct 11, 2024
18e94de
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 11, 2024
2b6e318
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 11, 2024
a6718bf
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
RuthDiG Oct 15, 2024
10df900
chore: incorporate code Review
RuthDiG Oct 15, 2024
07235bc
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 16, 2024
6edbfa8
chore: change naming etc
RuthDiG Oct 16, 2024
dc73b5a
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 17, 2024
b40efa0
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 17, 2024
d3ef6a3
refactor: MessageController and errorMessages in IncomingRequestsCont…
RuthDiG Oct 18, 2024
72613bc
fix: change Test setting
RuthDiG Oct 18, 2024
ca7767f
refactor: MessageController
RuthDiG Oct 18, 2024
9ff02bf
chore: incorporate code review
RuthDiG Oct 18, 2024
ddb92e3
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 18, 2024
0314a6e
refactor: comments
RuthDiG Oct 21, 2024
749a44f
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 21, 2024
a1d53a4
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 21, 2024
736b5bf
refactor: use PeerDeletionStatus
RuthDiG Oct 22, 2024
6ba5d73
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 22, 2024
6f9ab3c
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
RuthDiG Oct 24, 2024
41eed32
feat: add new test
RuthDiG Oct 24, 2024
3fba3a6
fix: change wrong test
RuthDiG Oct 24, 2024
dd1a76c
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 24, 2024
0488f68
refactor: error and add some tests
RuthDiG Oct 25, 2024
a7ed8cc
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 25, 2024
dfa2435
feat: add test for Attributssuccession
RuthDiG Oct 28, 2024
2fb6fbe
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 28, 2024
51b779d
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 28, 2024
4f2ef27
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 28, 2024
bc66bbb
fix: add waiting for event
RuthDiG Oct 29, 2024
9dbe0b9
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 29, 2024
d6c5f97
refactor: toBeDeleted in IsInDeletion
RuthDiG Oct 29, 2024
8d792b4
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Oct 29, 2024
6547ea2
refactor: wording
RuthDiG Oct 30, 2024
75cd6f6
test: use helper methods instead of re-inventing the wheel
jkoenig134 Oct 30, 2024
db9bd9c
refactor: make code readable using helper methods
jkoenig134 Oct 30, 2024
4b39aeb
refactor: check if only one recipient early if the content is a request
jkoenig134 Oct 30, 2024
bccfb11
fix: throw error instead of result
jkoenig134 Oct 30, 2024
471736b
feat: add tests
RuthDiG Oct 31, 2024
5065227
refactor: change place of testing
RuthDiG Oct 31, 2024
a98ced9
chore: remove comments
RuthDiG Oct 31, 2024
f5f5128
chore: remove other comment
RuthDiG Oct 31, 2024
7c067f3
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 4, 2024
af53490
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 4, 2024
930f35d
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 4, 2024
866cde3
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 5, 2024
09333a7
feat: move tests to notifications.test
RuthDiG Nov 5, 2024
afcbea0
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 6, 2024
3fb2883
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 7, 2024
ca2fadd
feat: change place for test and avoid enabling modules
RuthDiG Nov 8, 2024
e327ef3
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 12, 2024
e667444
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 12, 2024
7f4f928
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 12, 2024
3d62078
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 13, 2024
4179705
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
britsta Nov 18, 2024
dd555ae
refactor: move validation block of canDecide method of IncomingReques…
britsta Nov 18, 2024
c3b3e5b
refactor: place related tests together
britsta Nov 18, 2024
c5eedce
fix: failing tests due to an error thrown elsewhere
britsta Nov 18, 2024
ec00381
refactor: be consistent with written out error messages
britsta Nov 18, 2024
bb9094e
fix: wrong error code in tests
britsta Nov 18, 2024
fbb6600
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 18, 2024
5c79908
refactor: make use of auxiliary functions and only necessary expect s…
britsta Nov 18, 2024
5837b92
Merge branch 'feature/block-sending-messages-to-a-deleted-or-toBeDele…
britsta Nov 18, 2024
d21bf4e
refactor: remove redundant tests
britsta Nov 18, 2024
576e7b6
refactor: move tests to appropriate file
britsta Nov 18, 2024
7159836
refactor: move tests to right location
britsta Nov 18, 2024
57c9dae
chore: reduce file diffs
britsta Nov 18, 2024
5a2c75f
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 18, 2024
54d0e07
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 18, 2024
a2737eb
chore: remove empty line
britsta Nov 19, 2024
4db153c
refactor: use descriptive names and change error order
britsta Nov 19, 2024
a471beb
refactor: change order of thrown errors
britsta Nov 19, 2024
dd81355
refactor: change order of error messages
britsta Nov 19, 2024
be94949
refactor: simplify errors and define them in appropriate library
britsta Nov 20, 2024
fc7a6ee
fix: grammatical error
britsta Nov 20, 2024
1d7baf2
fix: failing tests due to strange bracket comparison
britsta Nov 20, 2024
16887b7
test: sending Messages requires existing of active or terminated Rela…
britsta Nov 21, 2024
f133677
fix: tests on a terminated Relationship
britsta Nov 21, 2024
3cbec4c
refactor: tests for sending Messages with recipient in deletion
britsta Nov 21, 2024
30a729e
test: more precise test names
britsta Nov 21, 2024
5f46573
refactor: emphasize key of error messages
britsta Nov 22, 2024
ff3774b
test: remove redundant tests
britsta Nov 22, 2024
ba9a441
test: make use of auxiliary function
britsta Nov 22, 2024
fbc6dc4
fix: missing bracket
britsta Nov 22, 2024
4daa01f
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 25, 2024
aff87e3
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 26, 2024
b61547c
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Nov 26, 2024
a6b79df
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
britsta Dec 2, 2024
8a1c196
chore: remove unneccessary empty lines
britsta Dec 2, 2024
7befefb
fix: failing test due to special error format of Transport library
britsta Dec 2, 2024
6d044a5
fix: prettier error
britsta Dec 2, 2024
a4a5ee0
chore: add empty line
britsta Dec 2, 2024
4763560
fix: failing test due to special error format of Transport library
britsta Dec 2, 2024
eca35ef
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Dec 2, 2024
12aec14
fix: failing test due to missing sync
britsta Dec 2, 2024
0b53e19
refactor: make variable constant
britsta Dec 2, 2024
d7ca3da
refactor: undo last commit
britsta Dec 2, 2024
47712a2
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Dec 2, 2024
6568c5e
Merge branch 'main' into feature/block-sending-messages-to-a-deleted-…
mergify[bot] Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .dev/compose.backbone.env
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
BACKBONE_VERSION=6.20.0

BACKBONE_VERSION=6.20.0
2 changes: 1 addition & 1 deletion packages/runtime/test/transport/messages.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ describe("Message errors", () => {
});
expect(result).toBeAnError(/.*/, "error.transport.messages.hasNeitherActiveNorTerminatedRelationship");
expect(result.error.message).toBe(
`The Message cannot be sent as there is neither an active nor a terminated Relationship to the recipient(s) with the following address(es): '${client5.address.toString()}'.`
`error.transport.messages.hasNeitherActiveNorTerminatedRelationship: The Message cannot be sent as there is neither an active nor a terminated Relationship to the recipient(s) with the following address(es): '${client5.address.toString()}'.`
);
});
});
Expand Down
Loading