Remove test_punet job from ci-sharktank.yml. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Nov 27, 2024
| @@ -22,45 +22,6 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| jobs: | |||
| test_punet: | |||
| name: "Integration Tests - punet" | |||
| runs-on: nodai-amdgpu-mi250-x86-64 | |||
There was a problem hiding this comment.
This base workflow should use standard github-hosted runners if possible. The test_with_data job is already a stretch.
Comment on lines
-60
to
-62
| - name: Run punet tests | ||
| run: | | ||
| pytest -v sharktank/ -m model_punet |
There was a problem hiding this comment.
This contains a very slow test: https://github.com/nod-ai/shark-ai/actions/runs/12047495763/job/33590136223#step:6:24
As commented on the PR that added it: #613 (comment)
marbre
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #613.
This job takes over an hour to run (specifically
test_punet_eager_fp16_validation) and is not suitable for presubmit.This is likely also not the right file for such tests, and if it was then the specialized tests should go under the generic
testjob, not at the top of the file.