Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sharktank] Unpin NumPy #694

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[sharktank] Unpin NumPy #694

merged 2 commits into from
Dec 16, 2024

Conversation

marbre
Copy link
Member

@marbre marbre commented Dec 13, 2024

numpy<2.0 is required for Windows with torch<2.4. Expanding testing on Windows with Python 3.12 and torch 2.4.1.

@ScottTodd
Copy link
Member

Discussed some of the test failures offline. Some of the "Data-dependent Tests" failures will be fixed along with ggml-org/llama.cpp#10127. Not sure about the Windows test failures.

@marbre
Copy link
Member Author

marbre commented Dec 16, 2024

Discussed some of the test failures offline. Some of the "Data-dependent Tests" failures will be fixed along with ggerganov/llama.cpp#10127. Not sure about the Windows test failures.

The "Data-dependent Tests" are indeed fixed with the gguf version 0.1.13 release. At the moment we only specify a minimum version (gguf>=0.11.0) and it would be fine to leave this as is.

`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing
on Windows with Python 3.12 and torch 2.4.1.
@marbre
Copy link
Member Author

marbre commented Dec 16, 2024

Moving all changes unrelated to unpinning NumPy to #697.

@marbre marbre marked this pull request as ready for review December 16, 2024 17:15
@marbre
Copy link
Member Author

marbre commented Dec 16, 2024

Discussed some of the test failures offline. Some of the "Data-dependent Tests" failures will be fixed along with ggerganov/llama.cpp#10127. Not sure about the Windows test failures.

The "Data-dependent Tests" are indeed fixed with the gguf version 0.1.13 release. At the moment we only specify a minimum version (gguf>=0.11.0) and it would be fine to leave this as is.

@ScottTodd you're okay with not raising the minimum version of gguf?

@marbre marbre requested a review from ScottTodd December 16, 2024 17:21
@ScottTodd
Copy link
Member

Discussed some of the test failures offline. Some of the "Data-dependent Tests" failures will be fixed along with ggerganov/llama.cpp#10127. Not sure about the Windows test failures.

The "Data-dependent Tests" are indeed fixed with the gguf version 0.1.13 release. At the moment we only specify a minimum version (gguf>=0.11.0) and it would be fine to leave this as is.

@ScottTodd you're okay with not raising the minimum version of gguf?

Yeah, though I don't see much harm in updating that minimum also.

@marbre marbre merged commit eb1d4c3 into nod-ai:main Dec 16, 2024
13 checks passed
@marbre marbre deleted the unpin-numpy branch December 16, 2024 17:28
IanNod pushed a commit to IanNod/SHARK-Platform that referenced this pull request Dec 17, 2024
`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing
on Windows with Python 3.12 and torch 2.4.1.
monorimet pushed a commit that referenced this pull request Jan 8, 2025
`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing
on Windows with Python 3.12 and torch 2.4.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants