-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sharktank] Unpin NumPy #694
Conversation
Discussed some of the test failures offline. Some of the "Data-dependent Tests" failures will be fixed along with ggml-org/llama.cpp#10127. Not sure about the Windows test failures. |
The "Data-dependent Tests" are indeed fixed with the gguf version 0.1.13 release. At the moment we only specify a minimum version ( |
`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing on Windows with Python 3.12 and torch 2.4.1.
Moving all changes unrelated to unpinning NumPy to #697. |
@ScottTodd you're okay with not raising the minimum version of gguf? |
Yeah, though I don't see much harm in updating that minimum also. |
`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing on Windows with Python 3.12 and torch 2.4.1.
`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing on Windows with Python 3.12 and torch 2.4.1.
numpy<2.0
is required for Windows withtorch<2.4
. Expanding testing on Windows with Python 3.12 and torch 2.4.1.