Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated]: crowdin sync #7560

Merged
merged 2 commits into from
Mar 22, 2025
Merged

[automated]: crowdin sync #7560

merged 2 commits into from
Mar 22, 2025

Conversation

github-actions[bot]
Copy link
Contributor

New Crowdin translations from the Node.js Crowdin project

@github-actions github-actions bot requested a review from a team as a code owner March 21, 2025 20:39
Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 21, 2025 8:43pm

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@avivkeller
Copy link
Member

This one looks a lot better.

Old vs New

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right to me and runs locally.
prettier also ran, unlike #7543

per policy, we need to wait 3 days during the weekend. would appreciate more eyes.

and thanks @Andrulko !!!!! ❤️

@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Mar 21, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 21, 2025
Copy link
Contributor Author

github-actions bot commented Mar 21, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 93 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller linked an issue Mar 22, 2025 that may be closed by this pull request
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to go!

@ovflowd ovflowd added this pull request to the merge queue Mar 22, 2025
Merged via the queue into main with commit 167a8f4 Mar 22, 2025
8 checks passed
@ovflowd ovflowd deleted the chore/crowdin branch March 22, 2025 11:33
@bmuenzenmeyer
Copy link
Collaborator

i typically like this to have more time for review (especially over the weekend) but considering its backlogged content state and our high scrutiny around it during resolution - it's probably fine

@ovflowd
Copy link
Member

ovflowd commented Mar 22, 2025

i typically like this to have more time for review (especially over the weekend) but considering its backlogged content state and our high scrutiny around it during resolution - it's probably fine

That's on me. I thought this was a PR opened for multiple weeks already. I believe we can still do a retroactive review if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

h1 header is not syncing correctly on some non-English pages
4 participants