stb_truetype: fix integer overflow in bitmap/SDF allocation#1867
Open
choongng wants to merge 1 commit into
Open
stb_truetype: fix integer overflow in bitmap/SDF allocation#1867choongng wants to merge 1 commit into
choongng wants to merge 1 commit into
Conversation
Add overflow checks before allocating bitmap buffers in stbtt_GetGlyphBitmapSubpixel and stbtt_GetGlyphSDF. When computing allocation size as w * h, the multiplication can overflow INT_MAX causing a small allocation followed by massive out-of-bounds writes during rendering. Return NULL when overflow would occur, consistent with existing allocation failure handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overflow checks before allocating bitmap buffers in stbtt_GetGlyphBitmapSubpixel and stbtt_GetGlyphSDF.
When computing allocation size as w * h, the multiplication can overflow INT_MAX causing a small allocation followed by massive out-of-bounds writes during rendering.
Return NULL when overflow would occur, consistent with existing allocation failure handling.