Skip to content

stb_truetype: fix integer overflow in bitmap/SDF allocation #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
choongng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

stb_truetype: fix integer overflow in bitmap/SDF allocation #1867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions stb_truetype.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,8 @@ int main(int arg, char **argv)
#define STBTT_assert(x) assert(x)
#endif

#include <limits.h>

#ifndef STBTT_strlen
#include <string.h>
#define STBTT_strlen(x) strlen(x)
Expand Down Expand Up @@ -3739,6 +3741,10 @@ STBTT_DEF unsigned char *stbtt_GetGlyphBitmapSubpixel(const stbtt_fontinfo *info
if (yoff ) *yoff = iy0;

if (gbm.w && gbm.h) {
if (gbm.w > INT_MAX / gbm.h) {
STBTT_free(vertices, info->userdata);
return NULL;
}
gbm.pixels = (unsigned char *) STBTT_malloc(gbm.w * gbm.h, info->userdata);
if (gbm.pixels) {
gbm.stride = gbm.w;
Expand Down Expand Up @@ -4610,6 +4616,10 @@ STBTT_DEF unsigned char * stbtt_GetGlyphSDF(const stbtt_fontinfo *info, float sc
float *precompute;
stbtt_vertex *verts;
int num_verts = stbtt_GetGlyphShape(info, glyph, &verts);
if (w > 0 && h > 0 && w > INT_MAX / h) {
if (verts) STBTT_free(verts, info->userdata);
return NULL;
}
data = (unsigned char *) STBTT_malloc(w * h, info->userdata);
precompute = (float *) STBTT_malloc(num_verts * sizeof(float), info->userdata);

Expand Down