(WIP) Add the ability to ship metrics directly to influxdb #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, there was no built-in way to ship metrics to an outside metrics server. After this commit, we pull in a script from puppetlabs/puppet-metrics-viewer that allows conversion of the metrics data we gather to influxdb or graphite format. This commit adds the initial support to enabling shipping of metrics directly to influxdb when given a hostname to connect to.
npwalker
changed the title
npwalker
commented
Jan 29, 2018
manifests/init.pp
Outdated
| @@ -19,6 +19,7 @@ | |||
| Array[String] $activemq_hosts = [ '127.0.0.1' ], | |||
| Integer $activemq_port = 8161, | |||
| Boolean $symlink_puppet_metrics_collector = true, | |||
| Optional[String] $influxdb_host = undef, | |||
There was a problem hiding this comment.
Instead of influxdb_host I think this should be Optional[Hash] influxdb_connection_info or something similar. Then we could collect all the various options the script accepts ( host, port, db name) without clogging up the parameters.
In fact we could just do a Hash $metrics_server_info and then have the user fill in graphite, influx, or whatever the next option might be.
npwalker
force-pushed
the
add_ability_to_ship_metrics_directly_to_influxdb
branch
from
60e161a to
8aa588d
Compare
Previously, we only allowed passing an influxdb host but you may want to pass a port or a different database type for influx. Additionally, you may prefer to ship to graphite. You can now do any of these by using the correct metrics_server_info hash.
npwalker
force-pushed
the
add_ability_to_ship_metrics_directly_to_influxdb
branch
from
8aa588d to
8ae4d14
Compare
|
@npwalker Should we add this to puppetlabs/puppet_metrics_collctor? This seems valuable to have in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there was no built-in way to ship metrics
to an outside metrics server.
After this commit, we pull in a script from
puppetlabs/puppet-metrics-viewer that allows conversion of the
metrics data we gather to influxdb or graphite format.
This commit adds the initial support to enabling shipping of metrics
directly to influxdb when given a hostname to connect to.