wiif: AP mode minor improvements #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
force-pushed
the
ap_build
branch
2 times, most recently
from
a3d51a0 to
7f5dd7d
Compare
jukkar
approved these changes
Dec 18, 2023
sachinthegreen
approved these changes
Dec 18, 2023
AP enable takes the same parameters as connect, so, update the help and also fix the optional parameter count when security is involved. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 9736cc7)
RSSI makes sense only for modes that have a single peer, so, add a station mode check. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit eaba474)
Regulatory domain supports both get and set, so, fix the argument counts. Upstream PR: zephyrproject-rtos/zephyr#66616 Signed-off-by: Chaitanya Tata <[email protected]>
rlubos
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.