Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiif: AP mode minor improvements #1426

Merged
merged 3 commits into from
Dec 19, 2023
Merged

wiif: AP mode minor improvements #1426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d3893
[nrf fromtree] wifi: shell: Fix AP argument checks and help
krish2718 Dec 14, 2023
bc56e60
[nrf fromtree] wifi: shell: Display RSSI only for station mode
krish2718 Dec 14, 2023
5088de7
[nrf fromlist] wifi: shell: Fix arg count for regulatory domain
krish2718 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions subsys/net/l2/wifi/wifi_shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,9 @@ static int cmd_wifi_status(const struct shell *sh, size_t argc, char *argv[])
wifi_security_txt(status.security));
shell_fprintf(sh, SHELL_NORMAL, "MFP: %s\n",
wifi_mfp_txt(status.mfp));
shell_fprintf(sh, SHELL_NORMAL, "RSSI: %d\n", status.rssi);
if (status.iface_mode == WIFI_MODE_INFRA) {
shell_fprintf(sh, SHELL_NORMAL, "RSSI: %d\n", status.rssi);
}
shell_fprintf(sh, SHELL_NORMAL, "Beacon Interval: %d\n", status.beacon_interval);
shell_fprintf(sh, SHELL_NORMAL, "DTIM: %d\n", status.dtim_period);
shell_fprintf(sh, SHELL_NORMAL, "TWT: %s\n",
Expand Down Expand Up @@ -1598,9 +1600,16 @@ SHELL_STATIC_SUBCMD_SET_CREATE(wifi_cmd_ap,
"Disable Access Point mode",
cmd_wifi_ap_disable,
1, 0),
SHELL_CMD_ARG(enable, NULL, "<SSID> [channel] [PSK]",
SHELL_CMD_ARG(enable, NULL,
"\"<SSID>\"\n"
"[channel number: 0 means all]\n"
"[PSK: valid only for secure SSIDs]\n"
"[Security type: valid only for secure SSIDs]\n"
"0:None, 1:WPA2-PSK, 2:WPA2-PSK-256, 3:SAE, 4:WAPI, 5:EAP, 6:WEP, 7: WPA-PSK\n"
"[MFP (optional: needs security type to be specified)]\n"
": 0:Disable, 1:Optional, 2:Required",
cmd_wifi_ap_enable,
2, 1),
2, 4),
SHELL_SUBCMD_SET_END
);

Expand Down Expand Up @@ -1675,7 +1684,7 @@ SHELL_STATIC_SUBCMD_SET_CREATE(wifi_commands,
"[-f]: Force to use this regulatory hint over any other regulatory hints\n"
"Note: This may cause regulatory compliance issues, use it at your own risk.",
cmd_wifi_reg_domain,
2, 1),
1, 1),
SHELL_CMD_ARG(mode, NULL, "mode operational setting\n"
"This command may be used to set the Wi-Fi device into a specific mode of operation\n"
"parameters:"
Expand Down