Add support to configure BSSID in Wi-Fi connect command #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rado17
commented
Apr 5, 2024
rado17
commented
- Use getopt API to process the arguments passed with connect command.
- Add support for BSSID configuration in connect call.
rado17
requested review from
sachinthegreen,
ajayparida,
D-Triveni,
VivekUppunda and
kapbh
rado17
force-pushed
the
connect_getopt_support
branch
from
aa7700f to
e0568c9
Compare
sachinthegreen
approved these changes
Apr 8, 2024
VivekUppunda
approved these changes
Apr 10, 2024
kapbh
approved these changes
Apr 10, 2024
ajayparida
requested changes
Apr 10, 2024
rado17
force-pushed
the
connect_getopt_support
branch
from
e0568c9 to
f3daef4
Compare
rado17
force-pushed
the
connect_getopt_support
branch
from
f3daef4 to
6014ccc
Compare
ajayparida
approved these changes
Apr 15, 2024
Use getopt API to process the arguments passed with connect command. Signed-off-by: Ravi Dondaputi <[email protected]> (cherry picked from commit 8256d02)
Add support for BSSID configuration in connect call. Signed-off-by: Ravi Dondaputi <[email protected]> (cherry picked from commit 73ed81c)
… parsing The commit 8256d02 introduced getopt parsing for the wifi connect command This needs to be updated for the wifi ap enable since ap enable also uses the same parsing as connect. The use of getopt removes the parameter ordering restrictions Signed-off-by: Brad Kemp <[email protected]> (cherry picked from commit 3e2c067)
Since `NONE` is a valid option for key management in `connect` command, we should remove the part in help text which says: "valid only for secure SSIDs". Upstream PR: zephyrproject-rtos/zephyr#71319 Signed-off-by: Ravi Dondaputi <[email protected]>
Having a `break` statement after `return` is redundant and needs to be removed. Upstream PR: zephyrproject-rtos/zephyr#71319 Signed-off-by: Ravi Dondaputi <[email protected]>
rado17
force-pushed
the
connect_getopt_support
branch
from
6014ccc to
28314bf
Compare
jukkar
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.