ir: Do not hash public keys to check orig/announced SN diff #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
fix/IR-compares-public-keys
branch
from
74db247 to
fc450c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2711 +/- ##
==========================================
- Coverage 28.78% 28.77% -0.01%
==========================================
Files 415 415
Lines 32388 32388
==========================================
- Hits 9324 9321 -3
- Misses 22230 22233 +3
Partials 834 834 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Jan 9, 2024
cthulhu-rider
approved these changes
Jan 12, 2024
pkg/innerring/processors/netmap/nodevalidation/availability/validator.go
Outdated
Show resolved
Hide resolved
Logs like "*number* differs *number*" may confuse, public keys are more common. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/IR-compares-public-keys
branch
from
fc450c6 to
e123e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs like "number differs number" may confuse, public keys are more common.