node/object: Improve SEARCH and GET #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
bugfix/object-search-server
branch
from
ecfcd5e to
04d99d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2722 +/- ##
==========================================
+ Coverage 22.20% 28.79% +6.58%
==========================================
Files 793 415 -378
Lines 47442 32385 -15057
==========================================
- Hits 10533 9324 -1209
+ Misses 36004 22225 -13779
+ Partials 905 836 -69 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
bugfix/object-search-server
branch
from
a862cb4 to
7b06cee
Compare
cthulhu-rider
changed the title
ObjectService.Search server enhancements
|
prelim refactor has been done to:
|
cthulhu-rider
force-pushed
the
bugfix/object-search-server
branch
from
a601804 to
5ac7bde
Compare
cthulhu-rider
force-pushed
the
bugfix/object-search-server
branch
2 times, most recently
from
dbf195c to
ba6bcd5
Compare
Previously, `ObjectService.Search` RPC server could write empty intermediate messages to the response stream. This did not break anything, but it resulted in a waste of cluster resources without any benefit. The case occurred due to the fact that the server sends at least one response message based on the search result on each of the container nodes, and empty results were not excluded. From now, if nothing is found on a single node, the server does not write a message to the stream. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, `ObjectService.Search` RPC server could send a request to a remote container node more than once in the context of processing a single client request. On the one hand, this makes no sense, since the state of the remote node is assumed to be unchanged in the context of a single request. On the other hand, the resource costs for a repeated request are prohibitively high - signatures, network, local storage. In practice, repetitions occurred in two cases: - storage policy specifics, e.g. with several replica (`REP`) rules - when switching processing to previous epochs: some nodes could "remain" in the container This is solved by storing the processed nodes in memory. Incurs much lower costs than repeated requests. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/object-search-server
branch
from
ba6bcd5 to
dcc7bd3
Compare
cthulhu-rider
changed the title
Same motivation and changes as in 67ababa. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/object-search-server
branch
from
dcc7bd3 to
2521e89
Compare
|
decided to leave standalone improvements here and continue policy optimizations in next PR |
roman-khimov
approved these changes
Apr 10, 2024
carpawell
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.