🦾 add @override to __init__.pyi, dtypes.pyi and _just.pyi

[guan404ming]

towards #301

• I think separate into 2-3 PRs is suitable to review or the PR would be too large to review
• resolve in this one: init.pyi, dtypes.pyi _just.pyi

[jorenham]

I vaguely remember having seen somewhere that only the getter needs a @override... But I can't seem to find anything about that in the typing spec, so I might be wrong here 🤔.

[guan404ming]

• I think separate into 2-3 PRs is suitable to review or the PR would be too large to review all changes

Yea makes sense. But I can't merge when there are errors reported, so maybe just turn the reportImplicitOverride off again for now.

You're right but when I turn off the reportImplicitOverride the CI ran in the error:

note: unused allowlist entry numpy(\..+)?\.(un)?signedinteger.__hash__
note: unused allowlist entry numpy(\..+)?\.floating.__hash__
note: unused allowlist entry numpy(\..+)?\.complexfloating.__hash__

could see in this action: https://github.com/numpy/numtype/actions/runs/13815493808/job/38647487183

currently investigating the cause of the error, do u have any idea about this error? 🧑‍💻

[jorenham]

• I think separate into 2-3 PRs is suitable to review or the PR would be too large to review all changes

Yea makes sense. But I can't merge when there are errors reported, so maybe just turn the reportImplicitOverride off again for now.

You're right but when I turn off the reportImplicitOverride the CI ran in the error:

note: unused allowlist entry numpy(\..+)?\.(un)?signedinteger.__hash__
note: unused allowlist entry numpy(\..+)?\.floating.__hash__
note: unused allowlist entry numpy(\..+)?\.complexfloating.__hash__

could see in this action: numpy/numtype/actions/runs/13815493808/job/38647487183

currently investigating the cause of the error, do u have any idea about this error? 🧑‍💻

This probably has something to do with python/mypy#18622, which apparently can be worked around by applying @override somewhere 🤷🏻.

Either way, it's good news I suppose.

I'm not able to reproduce it though 🤔
https://mypy-play.net/?mypy=latest&python=3.13&flags=strict%2Clocal-partial-types&gist=0ca4e075345f6e7af84f47d3bc0c8b28

---

edit:

TLDR; On main, if you remove these allowlist entries and run stubtest, you'll see errors like

error: numpy.floating.__hash__ is not a function
Stub: in file src/numpy-stubs/__init__.pyi:5784
def (numpy.floating[_NBitT`1 = Any]) -> int
Runtime:
None

and apparently one of the added @override's makes these errors go away for some reason

[guan404ming]

WHYYY? 🤷🏻

[jorenham]

WHYYY? 🤷🏻

I'm guessing it has to do with the position of the moon with respect to saturn, or maybe aliens.

[guan404ming]

You're right.🌝
https://www.astronomy.com/observing/sky-this-month-march-2025/

[jorenham]

You're right.🌝 astronomy.com/observing/sky-this-month-march-2025

🤣