Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI for different prediction tasks #19

Merged
merged 7 commits into from
Jun 1, 2020

Conversation

arielclj
Copy link
Contributor

No description provided.

@chrishkchris
Copy link
Contributor

@arielclj
From your code, there is a line
import ForkbaseStatus from "../components/ForkbaseStatus"
Is that your web page need forkbase for storage?
https://github.com/arielclj/singa-easy/blob/master/predictionweb/src/ImageClassification/ImageClassification.js#L20

@nudles
Copy link
Contributor

nudles commented May 22, 2020

  1. If we add a another task for object detection later, will there be a separate folder objdetectionweb/? Will it share some files with the predictionweb/?
  2. we also need an index page which lists all available tasks and links them to the corresponding pages (predictionweb or objdetectionweb).
  3. I suggest to organize the web code in this way
singa_easy/
            singa_easy/
            web/
                    index.html
                    tasks/
                               image_classification
                               object_detection
                               question_answering
                    xxxxx (some shared files among all the tasks)

@chrishkchris
Copy link
Contributor

chrishkchris commented May 26, 2020

@arielclj
Please take the following steps before I can merge the code:

  1. Please rearrange to location of folders as methioned above
  2. Remove all the "leftover code" of the last project you mentioned in the meeting
  3. Host the web UI on ncrs, so I can help to verify on my browser
  4. Add a .md file to show how to deploy

@chrishkchris
Copy link
Contributor

chrishkchris commented May 26, 2020

I have merged Thao's Q&A UI, #6 , you can see if the model zoo can use Thao's Q&A web page, and build by the same yarn install yarn start

You may use git fetch or git pull to fetch the update from the nusdbsystem:master branch, so your branch will have Thao's update

Your deployed UI: http://ncrs.d2.comp.nus.edu.sg:3002

@chrishkchris
Copy link
Contributor

chrishkchris commented May 27, 2020

error
the lime and gradcam cannot display
the old UI has the same problem @naili-xing, so this is not the problem of this PR

@chrishkchris
Copy link
Contributor

chrishkchris commented May 27, 2020

Her deployed UI is hosted on http://panda.d2.comp.nus.edu.sg:5000

Reminding task:

  1. Include Q&A in the application zoo

@chrishkchris
Copy link
Contributor

chrishkchris commented May 27, 2020

react app
the topic should be application zoo, but not react app, and I am not sure should keep the logo at singa-easy/web/public/logo192.png and logo512.png

@chrishkchris
Copy link
Contributor

As informed by @arielclj, Ariel will need some extra time to modify the Q&A UI to make it compatiable with this application zoo React app

@chrishkchris
Copy link
Contributor

chrishkchris commented May 31, 2020

@arielclj Please go into your github repo and merge this PR in your repo arielclj#1
This is because some variable name has changed in the backend, your UI need this update to fetch the correct variable name
When you merge that PR, this PR will be updated automatically since they are refering to the same branch

Adapt for the change of variable names in backend
@chrishkchris
Copy link
Contributor

@arielclj I put the inference job url here for you to test the Q&A UI ncrs.d2.comp.nus.edu.sg:3005/questionAnswer

@chrishkchris
Copy link
Contributor

I merge this PR first, @arielclj will need to submit another PR to display the answer according to the following design
ddc70b5115e21f3b732ff542cff6170

@chrishkchris chrishkchris merged commit f833638 into nusdbsystem:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants