Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web folder and the web app for Covid-19 Q&A #6

Merged
merged 8 commits into from
May 26, 2020

Conversation

pinpom
Copy link
Contributor

@pinpom pinpom commented May 6, 2020

Add the web folder and the web app for Covid-19 Q&A

web/index.html Outdated
}
}
};
xmlhttp.open("POST", "http://0.0.0.0:80/register", true);
Copy link
Contributor

@nudles nudles May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the url of the service on singa-auto?
make it as an input box to be set manually on the webpage.
once we launch the service on singa-auto, we can then paste the url to the box instead of changing the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fixed

web/index.html Outdated
</head>
<body>
<nav class="navbar navbar-expand navbar-light bg-light flex-column flex-md-row pipe-navbar justify-md-content-between">
<a class="navbar-brand" href="/"><img src="images/nus-logo.svg" width="66" height="30" class="d-inline-block" /> COVID-19 Question Answering engine</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just add the link to nus logo instead of uploading the svg file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done.

@chrishkchris
Copy link
Contributor

chrishkchris commented May 18, 2020

When this PR is completed and ready, can you deploy it at our server for verification or double checking? I will help to take a look of the deployed web. Thanks!

@pinpom
Copy link
Contributor Author

pinpom commented May 19, 2020

When this PR is completed and ready, can you deploy it at our server for verification or double checking? I will help to take a look of the deployed web. Thanks!

the web app is up at http://panda.d2.comp.nus.edu.sg:8000/. Put the inference service endpoint at the "input url" box, it will generate response at the bottom of the page

@chrishkchris
Copy link
Contributor

When this PR is completed and ready, can you deploy it at our server for verification or double checking? I will help to take a look of the deployed web. Thanks!

the web app is up at http://panda.d2.comp.nus.edu.sg:8000/. Put the inference service endpoint at the "input url" box, it will generate response at the bottom of the page

@delphieritas When your Q&A PR #18 is done, could you train it and and provide a inference job url for us to test the web app?

@chrishkchris chrishkchris changed the title add web folder add web folder and the web app for Covid-19 Q&A May 19, 2020
@chrishkchris chrishkchris changed the title add web folder and the web app for Covid-19 Q&A Add web folder and the web app for Covid-19 Q&A May 19, 2020
@chrishkchris chrishkchris mentioned this pull request May 20, 2020
@chrishkchris
Copy link
Contributor

chrishkchris commented May 26, 2020

@pinpom
Could you please reorganize the structure of files related to this PR following the comment in the PR #19

singa_easy/
            singa_easy/
            web/
                    index.html
                    tasks/
                               image_classification
                               object_detection
                               question_answering
                    xxxxx (some shared files among all the tasks)

In this case, only question_answering UI part is related to your PR.
If it is difficult without the singa_easy/web/index.html in #19, you can wait for #19 to be merged first

@pinpom
Copy link
Contributor Author

pinpom commented May 26, 2020

@pinpom
Could you please reorganize the structure of files related to this PR following the comment in the PR #19

singa_easy/
            singa_easy/
            web/
                    index.html
                    tasks/
                               image_classification
                               object_detection
                               question_answering
                    xxxxx (some shared files among all the tasks)

In this case, only question_answering UI part is related to your PR.
If it is difficult without the singa_easy/web/index.html in #19, you can wait for #19 to be merged first

I put all my web files into ./web/tasks/question_answering folder. it won't be affected or affect any other files in the web folder, i think

@chrishkchris
Copy link
Contributor

@pinpom
Could you please reorganize the structure of files related to this PR following the comment in the PR #19

singa_easy/
            singa_easy/
            web/
                    index.html
                    tasks/
                               image_classification
                               object_detection
                               question_answering
                    xxxxx (some shared files among all the tasks)

In this case, only question_answering UI part is related to your PR.
If it is difficult without the singa_easy/web/index.html in #19, you can wait for #19 to be merged first

I put all my web files into ./web/tasks/question_answering folder. it won't be affected or affect any other files in the web folder, i think

Thanks!

@chrishkchris
Copy link
Contributor

chrishkchris commented May 26, 2020

Last time you modified the code (concerning hardcoding the question area), could you please deploy it again so @delphieritas can test?
In the group meeting, we discussed the concern about the json string format when the UI server communicates with the inference job server, so please help her if she encounters any communication problem with the UI.
Thanks!

@pinpom
Copy link
Contributor Author

pinpom commented May 26, 2020

Last time you modified the code (concerning hardcoding the question area), could you please deploy it again so @delphieritas can test?
In the group meeting, we discussed the concern about the json string format when the UI server communicates with the inference job server, so please help her if she encounters any communication problem with the UI.
Thanks!

updated at the url http://panda.d2.comp.nus.edu.sg:8000/

@chrishkchris
Copy link
Contributor

SInce @arielclj need to combine her model zoo UI with this UI within the same build by YARN, I merge this PR first

@chrishkchris chrishkchris merged commit 41e1e25 into nusdbsystem:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants