feat: add support for OAuth PATs #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
force-pushed
the
add-pat-to-oauth
branch
from
64f7afe to
76db187
Compare
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
thedadams
force-pushed
the
add-pat-to-oauth
branch
4 times, most recently
from
1b90511 to
aea8d2f
Compare
StrongMonkey
approved these changes
Jan 22, 2025
What does this mean? |
Right now, every OAuth app that is created is available to every agent/workflow. After this change, that will no longer be the case. Agents and workflows must explicitly designate which OAuth apps they want to use on their |
iwilltry42
approved these changes
Jan 23, 2025
ivyjeong13
force-pushed
the
add-pat-to-oauth
branch
from
30887c1 to
e6ec645
Compare
ivyjeong13
reviewed
Jan 29, 2025
ivyjeong13
approved these changes
Jan 29, 2025
Instead of configuring and using OAuth, an app can specify that it supports using personal access tokens. If this is the case, then Obot will pass an extra environment variable to the oauth credential tool to indicate which integrations support tokens. If the oauth2 credential tool should prompt the user for a token instead of using OAuth, then Obot will not pass the environment variables that feed the URLs to the tool. A side effect of this change is that OAuth apps no longer default to global. Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
add-pat-to-oauth
branch
from
41fad2e to
055bed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of configuring and using OAuth, an app can specify that it supports using personal access tokens. If this is the case, then Obot will pass an extra environment variable to the oauth credential tool to indicate which integrations support tokens. If the oauth2 credential tool should prompt the user for a token instead of using OAuth, then Obot will not pass the environment variables that feed the URLs to the tool.
A side effect of this change is that OAuth apps no longer default to global.
Issue: #1372
Requires: obot-platform/tools#361