feat: add support to use PATs instead of OAuth #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
cjellick,
njhale,
StrongMonkey,
iwilltry42 and
g-linville
thedadams
force-pushed
the
oauth-pat-token-support
branch
from
ce01561 to
71f451d
Compare
g-linville
requested changes
Jan 22, 2025
oauth2/main.go
Outdated
| defer g.Close() | ||
|
|
||
| run, err := g.Run(context.Background(), "sys.prompt", gptscript.Options{ | ||
| Input: fmt.Sprintf(`{"metadata": %s,"message":"Please enter your personal access token for %s.","fields":"Token","sensative": true}`, b, integration), |
There was a problem hiding this comment.
Suggested change
| Input: fmt.Sprintf(`{"metadata": %s,"message":"Please enter your personal access token for %s.","fields":"Token","sensative": true}`, b, integration), | |
| Input: fmt.Sprintf(`{"metadata": %s,"message":"Please enter your personal access token for %s.","fields":"Token","sensitive": true}`, b, integration), |
If this typo exists on the gptscript end, then it should be fixed there too.
StrongMonkey
approved these changes
Jan 22, 2025
g-linville
approved these changes
Jan 24, 2025
thedadams
force-pushed
the
oauth-pat-token-support
branch
from
2e84aec to
5f2ba81
Compare
|
Pushed a change in design (in a new commit), so requesting reviews. |
njhale
reviewed
Jan 29, 2025
|
|
||
| --- | ||
| !metadata:*:supportsOAuthTokenPrompt |
There was a problem hiding this comment.
The description of this PR references an oauthPATSupported field. The field here is named differently. Is this intentional?
There was a problem hiding this comment.
I think that's changed in this PR obot-platform/obot#1387
StrongMonkey
approved these changes
Jan 29, 2025
njhale
approved these changes
Jan 29, 2025
Tools will now be able to specify, in their metadata, that their OAuth credential supports personal access tokens with the oauthPATSupported field being "true". If a tool does this, then the OAuth credential will prompt the user for a PAT instead of going through the OAuth flow. This change includes this field on the GitHub and Atlassian tools. Lastly, this change removes support for OAuth outside Obot. The OAuth credential tool will no longer look at the CLI config nor default to use the Gateway. Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
oauth-pat-token-support
branch
from
af7df7d to
400d33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools will now be able to specify, in their metadata, that their OAuth credential supports personal access tokens with the oauthPATSupported field being "true". If a tool does this, then the OAuth credential will prompt the user for a PAT instead of going through the OAuth flow.
This change includes this field on the GitHub and Atlassian tools.
Lastly, this change removes support for OAuth outside Obot. The OAuth credential tool will no longer look at the CLI config nor default to use the Gateway.
Issue: obot-platform/obot#1372