Add option to log name server information on apply #122
Conversation
Enable logging zone name server information on apply. This makes managing new zones easier, as otherwise one has to go look up the name server information for the zone separately in order to configure the domain registrar side records. The name server information is already present in the responses that the zone method receives, so adding it is easy enough. Downside is that a nested dict structure is required, which makes lookups a bit more complex.
| } | ||
| for z in zones | ||
| } | ||
| ) |
There was a problem hiding this comment.
If you'd rather avoid the nested dict and having to change all the places _zones is used you could instead go with a seperate dict, self._namerservers that just stores that information.
There was a problem hiding this comment.
Yeah I'll try that out and see how it looks/feels! I suppose there's nothing that wrong with nested dicts in general, just feels a bit icky to do these self.zones.get(zone.name, {}).get('id', False) tricks
There was a problem hiding this comment.
Decided to leave the nested dict after all, as now it's pretty simple to add new potential information from the zones to the dict. #123 perphaps wants to utilize the same approach, so it's perhaps nice to group all the non-record zone info under the same dict instead of always adding a new one, or what do you think?
rlaakkol
force-pushed
the
output-nameservers
branch
from
ea7ce94 to
0ca3b2a
Compare
| } | ||
| for z in zones | ||
| } | ||
| ) |
Enable logging zone name server information on apply. This makes managing new zones easier, as otherwise one has to go look up the name server information for the zone separately in order to configure the domain registrar side records.
The name server information is already present in the responses that the zone method receives, so adding it is easy enough. Downside is that a nested dict structure is required, which makes lookups a bit more complex.
The nested dict part might be a bit controversial, and I'm by no means a python dev, so any pointers on how to do this in a more elegant way I will gladly take!