-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting a plan #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments/suggestions inline for consideration. If they're applied the tests will need some tweaks to match.
Thanks these very really helpful. Added requirements.txt update and made changes more aligned with the codebase. |
Working on resolving the conflict with main now. |
Hi @oikarinen pls take a look at the two bits of changes I pushed up. First was just merging the changes made in #122 where things conflicted. Second made a quick pass at allowing the tests to pass with octoDNS w/o meta support. Other than that please push up an addition to CHANGELOG.md and this will be ready to go. |
Thanks a lot! Just pushed an update to the CHANGELOG.md so should be good to go. |
Thanks |
This pull request introduces support for managing Cloudflare plan types within the octodns_cloudflare provider. The change is implemented using a meta feature from octodns/octodns#1236
/cc @ross @rlaakkol
Key changes include:
__init__
method to accept and log theplan_type
parameter. (octodns_cloudflare/__init__.py
)zones
method to cache the plan information for each zone. (octodns_cloudflare/__init__.py
)_available_plans
,_resolve_plan_legacy_id
and_update_plan
methods to handle plan-related API calls and updates. (octodns_cloudflare/__init__.py
)