Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting a plan #127

Merged
merged 5 commits into from
Feb 5, 2025
Merged

feat: support setting a plan #127

merged 5 commits into from
Feb 5, 2025

Conversation

oikarinen
Copy link
Contributor

@oikarinen oikarinen commented Feb 3, 2025

This pull request introduces support for managing Cloudflare plan types within the octodns_cloudflare provider. The change is implemented using a meta feature from octodns/octodns#1236

/cc @ross @rlaakkol

Key changes include:

  • Update deps: octodns to 1.11.0 and others
  • Updated the __init__ method to accept and log the plan_type parameter. (octodns_cloudflare/__init__.py)
  • Modified the zones method to cache the plan information for each zone. (octodns_cloudflare/__init__.py)
  • Introduced _available_plans, _resolve_plan_legacy_id and _update_plan methods to handle plan-related API calls and updates. (octodns_cloudflare/__init__.py)
  • Updated README.md to document the new plan_type option.

Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments/suggestions inline for consideration. If they're applied the tests will need some tweaks to match.

octodns_cloudflare/__init__.py Outdated Show resolved Hide resolved
octodns_cloudflare/__init__.py Outdated Show resolved Hide resolved
octodns_cloudflare/__init__.py Outdated Show resolved Hide resolved
octodns_cloudflare/__init__.py Outdated Show resolved Hide resolved
@oikarinen oikarinen changed the title feat: support setting a plan WIP feat: support setting a plan Feb 4, 2025
@oikarinen
Copy link
Contributor Author

Comments/suggestions inline for consideration. If they're applied the tests will need some tweaks to match.

Thanks these very really helpful. Added requirements.txt update and made changes more aligned with the codebase.

@oikarinen oikarinen marked this pull request as ready for review February 4, 2025 14:16
README.md Outdated Show resolved Hide resolved
@ross
Copy link
Contributor

ross commented Feb 4, 2025

Working on resolving the conflict with main now.

@ross
Copy link
Contributor

ross commented Feb 4, 2025

Hi @oikarinen pls take a look at the two bits of changes I pushed up. First was just merging the changes made in #122 where things conflicted. Second made a quick pass at allowing the tests to pass with octoDNS w/o meta support.

Other than that please push up an addition to CHANGELOG.md and this will be ready to go.

@oikarinen
Copy link
Contributor Author

Hi @oikarinen pls take a look at the two bits of changes I pushed up. First was just merging the changes made in #122 where things conflicted. Second made a quick pass at allowing the tests to pass with octoDNS w/o meta support.

Other than that please push up an addition to CHANGELOG.md and this will be ready to go.

Thanks a lot! Just pushed an update to the CHANGELOG.md so should be good to go.

@ross ross merged commit 75a92f7 into octodns:main Feb 5, 2025
7 checks passed
@ross
Copy link
Contributor

ross commented Feb 5, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants