Automatically add hub/device tabs when selected in the editor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of waiting for the hardware to be scanned, add tabs when the specific headstage is selected - Update tab names. Now headstage tabs include their name and hub, while device names include the device index and device name - Refactored the OnixDevice array to be a vector of smart pointers, which removed the leaked device - Add static methods to the PortController class that make it easier to convert the port name to another value - Remove dynamic parameter additions in Neuropixels_1, manually tracking the path
- Check which tabs are open and which devices are connected - Refresh combo box selection if new tabs are added - Update Neuropixels 1.0f device names - Utilize the base class device pointer, and cast to the correct device when needed - Make sure that the electrode selection is updating the bank/channel/shank/electrode arrays - Rename to source from onixSource/thread/etc. - Add method to find all unique ports from a list of indices - Add method to add headstage options to the combobox - Update the settings interface data source - Change updateSettings() to be a boolean method - Updated error reporting for Neuropixels 1.0f - Use std::map to hold key-value pairs, such as index and device type - Add check during isReady() that ensures any hardware that is connected contains a valid settings interface
- Ensures that no additional memory leaks exist - Change variable name from dataSource to device
- Move raw pointers to private: as needed - Remove unused buffers from base class
- Add methods to automate asking the user what to do - Add using statement to simplify creating a vector of shared_ptrs for OnixDevices - Started adding constexpr strings to maintain compatibility for headstage names across the plugin - Correct metadata for Neuropixels 1.0f on creation
- Some files were unable to be resolved during merge, and had to be manually modified after merging
- If no voltage override is given, the default text is "Auto" - Changed the location of the voltage override components - Remove "Hub" from tab name - Removed test headstage from code prior to merging - Added checks for valid contexts before reading/writing registers - Only configure the device, and subsequently reset the context, if the hardware is connected - Modify error messages: remove hyphen, except for when there is a Note, change wording to "if the correct headstage is connected" - Disable dropdown menus when hardware is connected to prevent
jonnew
reviewed
Mar 19, 2025
jonnew
reviewed
Mar 19, 2025
jonnew
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full functionality for tabs to be added when selected in the editor. This means that settings can be modified prior to the hardware being connected to the plugin.