Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

myhealth: smoother dropdown (fixes #5312) #5329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

myhealth: smoother dropdown (fixes #5312) #5329

wants to merge 2 commits into from

Conversation

Avinash-Codes
Copy link
Member

fixes #5312

@Avinash-Codes Avinash-Codes linked an issue Feb 20, 2025 that may be closed by this pull request
better form #5312
Open
Okuro3499
Okuro3499 requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icon looks misplaced
Screenshot_20250221_143425

can it be same to level in become member and have the text 'contact preference' above it
Screenshot_20250221_143524

pavi38
pavi38 requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@pavi38 pavi38 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Avinash-Codes I think this spinner was for, if the emergency contact entered is email or phone number. Not the preferred method of contact.

Okuro3499
Okuro3499 requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the dropdown icon and place it between emergency contact and contact which also not a must to be on the same line
Screenshot_20250224_145345

@deeppp15 deeppp15 self-requested a review February 27, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okuro3499 Okuro3499 Okuro3499 requested changes

@pavi38 pavi38 pavi38 requested changes

@deeppp15 deeppp15 Awaiting requested review from deeppp15

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes requested peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better form
4 participants
@Avinash-Codes @Okuro3499 @deeppp15 @pavi38