Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myhealth: smoother dropdown (fixes #5312) #5329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 31 additions & 9 deletions app/src/main/res/layout/activity_add_my_health.xml
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,6 @@
android:backgroundTint="@color/daynight_textColor"
android:textColor="@color/daynight_textColor" />
</com.google.android.material.textfield.TextInputLayout>

<Spinner
android:id="@+id/spn_contact_type"
style="@style/SpinnerItemStyle"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
android:layout_weight="1"
android:padding="@dimen/padding_large" />
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/et_contact"
android:layout_width="0dp"
Expand Down Expand Up @@ -243,6 +234,37 @@
android:textColor="@color/daynight_textColor" />
</com.google.android.material.textfield.TextInputLayout>

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical"
android:padding="@dimen/padding_normal">

<TextView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
android:padding="@dimen/padding_small"
android:text="@string/contact_preference"
android:textColor="@color/daynight_textColor" />
<RelativeLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:background="@drawable/border"
android:padding="@dimen/padding_normal"
android:textColor="@color/daynight_textColor">

<Spinner
android:id="@+id/spn_contact_type"
style="@style/SpinnerItemStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="@dimen/padding_small"
android:background="@android:color/transparent"
android:spinnerMode="dropdown" />
</RelativeLayout>
</LinearLayout>

<Button
android:id="@+id/btn_submit"
android:layout_width="wrap_content"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/spinner_item_white.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<TextView xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/spinner_text"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:textColor="@color/md_white_1000"
android:textSize="16sp"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1239,5 +1239,6 @@
<string name="go_to_mylibrary">Go To MyLibrary</string>
<string name="choose_an_option">Choose an option</string>
<string name="welcome_back">Welcome back %1$s !</string>
<string name="contact_preference">contact preference</string>

</resources>