-
Notifications
You must be signed in to change notification settings - Fork 959
jmx add jvm metrics yaml #13392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jmx add jvm metrics yaml #13392
Conversation
…nstrumentation into jvm-jmx-metrics
...etrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/MetricsVerifier.java
Outdated
Show resolved
Hide resolved
...trics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/TargetSystemTest.java
Outdated
Show resolved
Hide resolved
.../library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/assertions/JmxAssertj.java
Outdated
Show resolved
Hide resolved
...ibrary/src/test/java/io/opentelemetry/instrumentation/jmx/rules/assertions/MetricAssert.java
Outdated
Show resolved
Hide resolved
I tried to refactor the test assertions to only rely on the ones provided by the SDK (using
Overall I think it would be more beneficial if we extend the SDK |
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
All the test infrastructure code changes have been copied to #13597 to make review easier and allow reusing it. |
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
...cs/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/JvmTargetSystemTest.java
Outdated
Show resolved
Hide resolved
…etry/instrumentation/jmx/rules/JvmTargetSystemTest.java Co-authored-by: Jay DeLuca <[email protected]>
jvm.yaml
in the JMX library so it can be reused by jmx-scraper in contrib.Part of #13238 with a scope limited to JVM metrics.
~75% of this PR is for adding test infrastructure similar to contrib repository, it has been moved to #13597 separate PR to make review easier.
PR opened as draft, not ready for review nor being merged yet.UPDATE: Now ready to be merged, the test infrastructure code that is included could be reviewed and merged separately with #13597 .
TODOs
jvm.memory.type
metric attribute once jmx metrics with yaml: need ability to post-process some attribute values #13361 is implementedjvm.cpu.time
once JMX Metrics with yaml: needed unit conversion mechanism #13369 is implemented (optional, can be done as a follow-up PR).jvm.cpu.time
andjvm.cpu.recent_utilization
) that might return-1
and would thus not fit their semconv definitions.