-
Notifications
You must be signed in to change notification settings - Fork 685
Conformity of client intereptor(s) with the official grpc.*ClientInterceptor
-interfaces
#1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…terceptor-interfaces
@srikanthccv Does anything need to be addressed in this PR before it can be merged? |
@srikanthccv Can we help get this across the line? |
This needs to be rebased |
@CoLa5 Do you mind if I take over this PR and get this work across the line? Having metrics for gRPC would be incredibly useful for production services. |
I have opened a new pull request here: #3384 I'd appreciate it if the CI could be enabled and it could get reviewed within the next week. I'll likely follow up and start working on the metrics implementation as well. |
Description
Currently, the
OpenTelemetryClientInterceptor
is based on an external implementation of grpc client interceptors whose source code lies in the packagegrpcext
.To support the official
grpc.UnaryUnaryClientInterceptor
-,grpc.UnaryStreamClientInterceptor
-,grpc.StreamUnaryClientInterceptor
-, andgrpc.StreamStreamClientInterceptor
-interface, which are supported officially in grpc since v1.8.0, the source code of the_client.py
-module is adapted.Hereby, the design of the
_client.py
-module orientates itself strongly on the design of the_aio_client.py
-module. Thus, the external implementation of the grpc client interceptors can be removed (packagegrpcext
). Also, theRpcInfo
-class in theutilities.py
-module is not required any more.The
_aio_client.py
-module must be adapted so that the_BaseAioClientInterceptor
becomes independent of the_BaseClientInterceptor
.The
test_client_interceptor_trace_context_propagation
-tests are adapted according to the same test in thetest_aio_client_interceptor.py
-module to remove the dependency on the external implementation of the grpc client interceptors, which are located in the packagegrpcext
.The documentation of the code in the
__init__.py
is adapted accordingly.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e test-instrumentation-grpc
.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.