add UKV

[peterdudfield]

Pull Request

Description

Add UKV MO model. This has x and y as main dims, with lat and lot as a grid.

• this gets new results every hour
• lat long seem to be still in the zarr (check TODO)

We might need to add #222 so that not data is not pulled twice

openclimatefix/ocf-infrastructure#697

How Has This Been Tested?

• ran locally
• added a test

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[peterdudfield]

This is my first try at this @devsjc, I wonder if you could have a look and advise

[devsjc]

A great first effort Peter! Hopefully it wasn't too much of a pain to figure out, I like to think the model API is fairly self-explanatory, but its certainly easy for me to say...!

[peterdudfield]

I havent quite got this working yet. The trick thing is lat and lot are coordinates but not dims in the data array.

One option is to not save the lat/lon coordinates, but I think it would be good to do this

[peterdudfield]

Looks like right now it doesnt have a lattitude or longitude coordinate. The old one has these as function of (x,y). I think it would be worth getting these in before merging

[peterdudfield]

PLan to not save lat and long, byt make x_osgb and y_osgb