Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide up integration tests #224

Merged
merged 28 commits into from
Jan 24, 2025
Merged

Divide up integration tests #224

merged 28 commits into from
Jan 24, 2025

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 18, 2024

Pull Request

Description

  • Split unit and integration tests
  • On PR, dont run integration tests. This is so external users and PRs get passing tests

#187

How Has This Been Tested?

CI tests for both PR and none PR

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.70%. Comparing base (5093843) to head (822c1d4).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   61.76%   58.70%   -3.06%     
==========================================
  Files          25       27       +2     
  Lines        1020     1085      +65     
==========================================
+ Hits          630      637       +7     
- Misses        390      448      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zakwatts zakwatts mentioned this pull request Jan 24, 2025
5 tasks
@zakwatts zakwatts merged commit 6d0e697 into main Jan 24, 2025
5 checks passed
@peterdudfield peterdudfield deleted the divide-up-integration-tests branch January 30, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants