feat: Add LightGBM model with enhanced feature engineering (Issue #30) - #336
Closed
Raakshass wants to merge 3 commits into
Closed
feat: Add LightGBM model with enhanced feature engineering (Issue #30)#336Raakshass wants to merge 3 commits into
Raakshass wants to merge 3 commits into
Conversation
- Update requires-python to >=3.11,<3.13 to explicitly support Python 3.12 - Update huggingface_hub from 0.17.3 to 0.21.4 for Py3.12 compatibility - Disable HuggingfaceHubIntegration in sentry_sdk to fix version conflicts Fixes openclimatefix#333
Raakshass
force-pushed
the
feat/new-model-challenge-issue30
branch
from
February 3, 2026 15:34
02ffb16 to
9165569
Compare
Contributor
Author
|
Hi @peterdudfield, the CI is failing due to pre-existing issues in the main branch:
My new files all pass |
6 tasks
Contributor
Author
|
Closing in favor of #341 which has a cleaner implementation. Sorry for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR introduces a new LightGBM-based solar power predictor with enhanced feature engineering to improve forecast accuracy for Issue #30 (New Model Challenge).
Key additions:
model="lgbm"option to run_forecast()Feature Engineering includes:
Fixes #30
How Has This Been Tested?
Added comprehensive unit tests in tests/test_v3_lightgbm.py covering:
Solar position calculations (elevation/azimuth ranges, daylight detection)
Cyclical time encoding (value ranges, continuity)
Derived weather features (cloud cover weighting, clear sky factor)
Panel orientation factors (incidence calculations)
FeatureEngineer class integration
Yes
If your changes affect data processing, have you plotted any changes?
Checklist: