-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache .next/cache between builds #185
Conversation
883d7c8
to
53ffb46
Compare
@ehmicky any specific thoughts on these questions in the PR desc? 🙏 how will this behave with the pizzafox plugin? |
The cache utility deletes the destination file/directory before both saving and restoring. So I believe it should be idempotent, and running both However, I would suggest manually testing it before merging this PR. The production behavior of the caching utility is different from local builds, so I would suggest testing both (or at least production). If it turned out to be incompatible, I would suggest:
When it comes to testing it, I would suggest using a fixture directory then:
|
53ffb46
to
e810b4b
Compare
i manually tested. as for automated tests, i'm not sure how we'd "run the plugin" with the real valid utils.cache hook? |
The above was assuming the tests would be run using Another option would be to spy on the mocked |
b3a0d3e
to
8cb478c
Compare
1c64f39
to
2555815
Compare
Fixes #63
questions: