Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onboarding link in README #205

Closed
wants to merge 1 commit into from

Conversation

Swiddis
Copy link
Contributor

@Swiddis Swiddis commented Jun 27, 2024

Description

The current org readme links to the onboarding guide at https://github.com/opensearch-project/.github/blob/main/profile/ONBOARDING.md, which is a 404. This updates the link to the correct location.

It may at some point be worthwhile to run a link checker in the repo to find other dead links.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The current org readme links to the onboarding guide at https://github.com/opensearch-project/.github/blob/main/profile/ONBOARDING.md, which is a 404. This updates the link to the correct location.

Signed-off-by: Simeon Widdis <[email protected]>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Want to make another PR to add that linter? I've seen lycheeverse/lychee-action in use [1]

  • [1] lychee Link Checker job in CI.yml

@Swiddis Swiddis mentioned this pull request Jun 28, 2024
@Swiddis
Copy link
Contributor Author

Swiddis commented Jun 28, 2024

It may be better to close this in favor of #206 since those changes are a superset of this. Will leave this open for now since it's already approved and fixes the only Lychee true-positive.

@dblock
Copy link
Member

dblock commented Jul 1, 2024

Closing after #206 .

@dblock dblock closed this Jul 1, 2024
@Swiddis Swiddis deleted the patch-2 branch July 8, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants