Add link checker #206
Merged
Add link checker #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
dblock
reviewed
Jun 28, 2024
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
CEHENKLE,
mch2,
peternied and
saratvemulapalli
as code owners
I found one that works and says it's 3 redirects, but Lychee is still failing with the error even after setting |
dblock
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on #205, this PR adds the Lychee link checking action we use on our team. I also went through and fixed all the lychee issues for the repo.
The
issueslinks were false alarms since they did work correctly in the GitHub UI, but I still think refactoring makes it more portable, and adding exemptions to the checker for this would probably be more effort than it's worth.The playground link being tricky is known, it gives a "too many redirects" error even after increasing the number of redirects. We ended up ignoring it in our repo as well, since this behavior happens even for dedicated redirect trackers like deref. It's possible this behavior is due to some sort of bot protection.
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.