Replace array by iterable in return type. Fix #307 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainruaud
requested review from
VachaShah,
dblock,
harshavamsi,
shyim,
saimedhi and
kimpepper
as code owners
Signed-off-by: Romain Ruaud <[email protected]>
romainruaud
force-pushed
the
fix_return-type
branch
from
36f4b1e to
5d1b11b
Compare
|
can you add an changelog? |
Signed-off-by: Romain Ruaud <[email protected]>
romainruaud
force-pushed
the
fix_return-type
branch
from
3f35749 to
df11e00
Compare
|
Done @shyim ! |
shyim
approved these changes
Feb 24, 2025
|
thank you! |
|
Looks like this was a change in a generated file, not the template, see #312 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
This ensures that
Client::performRequest()has the same return type than theTransport::sendRequest()since it was changed in #300Issues Resolved
Fixes #307