Add/update several repos in dashboards-plugins/.meta #209
Conversation
msfroh
requested review from
dblock,
saratvemulapalli,
tlfeng,
VachaShah and
ohltyler
as code owners
| "customImportMapDashboards": "[email protected]:opensearch-project/dashboards-maps.git" | ||
| "customImportMapDashboards": "[email protected]:opensearch-project/dashboards-maps.git", | ||
| "searchRelevanceDashboards": "[email protected]:opensearch-project/dashboards-search-relevance.git", | ||
| "opensearch-dashboards-functional-test": "[email protected]:opensearch-project/opensearch-dashboards-functional-test.git" |
There was a problem hiding this comment.
opensearch-dashboards-functional-test isn't really a dashboards plugin, so I wasn't sure what to use for the key here.
Should this one be moved to the top-level .meta file?
There was a problem hiding this comment.
This meta file is only for plugins, I would rather remove repo's which dont release plugins.
There was a problem hiding this comment.
Is there a better place to put opensearch-dashboards-functional-test?
I saw on opensearch-project/opensearch-build#3081 that the automation to cut per-repo release issues initially missed it and @gaiksaya manually cut the issue a week later. I'd like to do what I can to make sure that every repo gets hit by the automation next time. (I see that all of these repos are present in https://github.com/opensearch-project/project-meta/blob/main/.meta )
There was a problem hiding this comment.
The project-meta contains repositories that are not a part of distribution release cycle. Rather are stand-alone components. We can add opensearch-dashboards-functional-test under dashboards as in a way that fits as it contains integration tests for all plugins and follows core branching strategy. Let me know what you think.
There was a problem hiding this comment.
As long as you guys are convinced opening issues across dashboards plugins is relevant to opensearch-dashboards-functional-test, I am good with it.
msfroh
force-pushed
the
missing-repos
branch
2 times, most recently
from
8d47a79 to
58dd9dd
Compare
The following repos were missed by the release ticketing automation for the 2.6 OpenSearch release, because they were either missing from the .meta files (dashboards-search-relevance and opensearch-dashboards-functional-test) or they had out-of-date repo URIs (dashboards-notifications, dashboards-query-workbench, and dashboards-observability). Signed-off-by: Michael Froh <[email protected]>
msfroh
force-pushed
the
missing-repos
branch
from
58dd9dd to
b0efba0
Compare
|
Looks like I duplicated the effort #210 my bad! |
|
Discarding this PR, since the changes were made in #210 |
The following repos were missed by the release ticketing automation for the 2.6 OpenSearch release, because they were either missing from the .meta files (dashboards-search-relevance and opensearch-dashboards-functional-test) or they had out-of-date repo URIs (dashboards-notifications, dashboards-query-workbench, and dashboards-observability).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.