-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/update several repos in dashboards-plugins/.meta #209
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,16 @@ | ||
| { | ||
| "projects": { | ||
| "queryWorkbenchDashboards": "[email protected]:opensearch-project/sql.git", | ||
| "queryWorkbenchDashboards": "[email protected]:opensearch-project/dashboards-query-workbench.git", | ||
| "alertingDashboards": "[email protected]:opensearch-project/alerting-dashboards-plugin.git", | ||
| "notificationsDashboards": "[email protected]:opensearch-project/notifications.git", | ||
| "notificationsDashboards": "[email protected]:opensearch-project/dashboards-notifications.git", | ||
| "securityDashboards": "[email protected]:opensearch-project/security-dashboards-plugin", | ||
| "indexManagementDashboards": "[email protected]:opensearch-project/index-management-dashboards-plugin.git", | ||
| "anomalyDetectionDashboards": "[email protected]:opensearch-project/anomaly-detection-dashboards-plugin.git", | ||
| "reportsDashboards": "[email protected]:opensearch-project/dashboards-reports.git", | ||
| "observabilityDashboards": "[email protected]:opensearch-project/observability.git", | ||
| "observabilityDashboards": "[email protected]:opensearch-project/dashboards-observability.git", | ||
| "ganttChartDashboards": "[email protected]:opensearch-project/dashboards-visualizations.git", | ||
| "customImportMapDashboards": "[email protected]:opensearch-project/dashboards-maps.git" | ||
| "customImportMapDashboards": "[email protected]:opensearch-project/dashboards-maps.git", | ||
| "searchRelevanceDashboards": "[email protected]:opensearch-project/dashboards-search-relevance.git", | ||
| "opensearch-dashboards-functional-test": "[email protected]:opensearch-project/opensearch-dashboards-functional-test.git" | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opensearch-dashboards-functional-testisn't really a dashboards plugin, so I wasn't sure what to use for the key here.Should this one be moved to the top-level .meta file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This meta file is only for plugins, I would rather remove repo's which dont release plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better place to put
opensearch-dashboards-functional-test?I saw on opensearch-project/opensearch-build#3081 that the automation to cut per-repo release issues initially missed it and @gaiksaya manually cut the issue a week later. I'd like to do what I can to make sure that every repo gets hit by the automation next time. (I see that all of these repos are present in https://github.com/opensearch-project/project-meta/blob/main/.meta )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project-meta contains repositories that are not a part of distribution release cycle. Rather are stand-alone components. We can add
opensearch-dashboards-functional-testunder dashboards as in a way that fits as it contains integration tests for all plugins and follows core branching strategy. Let me know what you think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you guys are convinced opening issues across dashboards plugins is relevant to
opensearch-dashboards-functional-test, I am good with it.