GCP image generation #519
Draft
GCP image generation #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
beraldoleal
force-pushed
the
gcp-image-generation
branch
2 times, most recently
from
65ab1f5 to
be748fd
Compare
openshift-merge-robot
added
the
needs-rebase
Those scripts are needed the same way we do with azure and aws. Signed-off-by: Beraldo Leal <[email protected]>
This is not installing when running the docker locally. Propably I will drop this commit. Signed-off-by: Beraldo Leal <[email protected]>
Those methods will be duplicated again with GCP, lets centralize them inside lib.sh. Signed-off-by: Beraldo Leal <[email protected]>
This is temporary, podman-docker doesn't have docker buildx ... Signed-off-by: Beraldo Leal <[email protected]>
Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
gcp-image-generation
branch
from
be748fd to
291683f
Compare
openshift-merge-robot
removed
the
needs-rebase
snir911
reviewed
Feb 6, 2025
|
|
||
| # TODO: This means we are installing the azure rpms for all providers? |
There was a problem hiding this comment.
no, by following it you'll see it's actually installing general set of binaries, i'm not sure it's implemented like, it may need a fix
| # Ensure CLOUD_PROVIDER is set to gcp | ||
| [[ -z "${CLOUD_PROVIDER}" || "${CLOUD_PROVIDER}" != "gcp" ]] && error_exit "CLOUD_PROVIDER is empty or not set to gcp" | ||
|
|
||
| [[ -z "${AWS_ACCESS_KEY_ID}" ]] && error_exit "AWS_ACCESS_KEY_ID is not set" |
There was a problem hiding this comment.
remove all the aws related vars
|
|
||
| # Download gcloud cli | ||
| # TODO | ||
| tee -a /etc/yum.repos.d/google-cloud-sdk.repo << EOM |
| tar -cvzf build/disk.tar.gz -C build disk.raw | ||
|
|
||
| # Create bucket if doesn't exist | ||
| export GCP_REGION="us-central1" |
There was a problem hiding this comment.
Is this the only region supported or bucket is available in all regions?
| echo "${GCP_IMAGE_NAME} created successfully" | ||
| } | ||
|
|
||
| # Function to create or update podvm-images configmap with all the amis |
| # Create bucket if doesn't exist | ||
| export GCP_REGION="us-central1" | ||
| export GCP_BUCKET_NAME="peerpods-bucket" | ||
| if ! gsutil ls -b "gs://${GCP_BUCKET_NAME}/" &>/dev/null; then |
There was a problem hiding this comment.
I'd encapsulate the uploading part and image creation part to different function as it may be useful to the uploading disk images that comes from other sources (bootc, user's image etc..)
snir911
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
In order to support GCP with the next release, we need to generate the images automatically in case image is not configured by the user.
- What I did
I followed the same approach used by aws and azure. This is a WiP.
- How to verify it
WiP
- Description for the changelog
Added support for a new cloud provider: Google Cloud Platform (GCP).