Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeset and job config for multicell #1683

Merged

Conversation

bogdando
Copy link
Contributor

@bogdando bogdando commented May 13, 2024

Add nodeset for multicell adoption jobs that replicates
the multinode adoption nodeset, but custom networks and hostnames.

Add a non-voting WIP job for multicells development (via node
autoholds, as there is no other way to set up dev env)

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Required-By: openstack-k8s-operators/install_yamls#826
Required-By: https://review.rdoproject.org/r/c/rdo-jobs/+/53192

JIRA OSPRH-6548

@bogdando bogdando requested a review from marios May 13, 2024 12:53
@openshift-ci openshift-ci bot requested review from arxcruz and katarimanojk May 13, 2024 12:53
@github-actions github-actions bot marked this pull request as draft May 13, 2024 12:53
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

Copy link

Zuul encountered a syntax error while parsing its configuration in the
repo openstack-k8s-operators/ci-framework on branch main. The error was:

while scanning an alias
in "openstack-k8s-operators/ci-framework/zuul.d/adoption.yaml@main", line 320, column 16
did not find expected alphabetic or numeric character
in "openstack-k8s-operators/ci-framework/zuul.d/adoption.yaml@main", line 320, column 28

rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 13, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683
Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 13, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683
Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 13, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

External dependency
openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
@bogdando bogdando marked this pull request as ready for review May 13, 2024 13:21
@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel May 13, 2024 13:22
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/276b02b0e69e444da92c75641cf827d1

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 04s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 55s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 4s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 00s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 35s

rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 14, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

External dependency
openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 20, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

External dependency
openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
@bogdando
Copy link
Contributor Author

recheck retry lmit

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bef3f6e50d31435bb95147aa8cb38e7a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 41m 06s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 22s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 23m 46s
✔️ noop SUCCESS in 0s
cifmw-pod-ansible-test FAILURE in 5m 44s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 21s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 08s

zuul.d/adoption.yaml Outdated Show resolved Hide resolved
@bogdando
Copy link
Contributor Author

recheck cifmw-pod-ansible-test

rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 21, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 21, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

External dependency
openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 21, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 21, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario.

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
Add nodeset for multicell adoption jobs that replicates
the multinode adoption nodeset, but custom networks and hostnames.

Add a non-voting WIP job for multicells development (via node
autoholds, as there is no other way to set up dev env)

Signed-off-by: Bohdan Dobrelia <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 28, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 28, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 28, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/install_yamls#826
Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 31, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/install_yamls#826
Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 31, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/install_yamls#826
Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 31, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/install_yamls#826
Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request May 31, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/install_yamls#826
Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
@bogdando
Copy link
Contributor Author

@marios PTAL, I've addressed you concerns

rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Jun 10, 2024
Support deployment of single cell HA tripleo,
and multi-cell non-HA reduced footrpint.

Re-tartget data-plane-adoption-osp17-multinode-to-extracted-crc-no-ceph
for multi-cell setup scenario in order to develop it via node autoholds
(there is no other way to deploy).

JIRA https://issues.redhat.com/browse/OSPRH-6548

Depends-On: openstack-k8s-operators/install_yamls#826
Depends-On: openstack-k8s-operators/ci-framework#1683

Change-Id: I6712a0843b992d7c8ccc91be93bce04fd31fcd08
Signed-off-by: Bogdan Dobrelya <[email protected]>
Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thanks, this way it is cleaner and you can work independently of the other multinode job

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2024
@bogdando
Copy link
Contributor Author

many thanks for reviews, can we merge it now?

Copy link
Contributor

@cescgina cescgina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 68c2720 into openstack-k8s-operators:main Jun 11, 2024
7 checks passed
@bogdando bogdando deleted the mutl-cell branch June 28, 2024 12:51
@bogdando
Copy link
Contributor Author

/cherry-pick 18.0.0

@openshift-cherrypick-robot

@bogdando: cannot checkout 18.0.0: error checking out "18.0.0": exit status 1 error: pathspec '18.0.0' did not match any file(s) known to git

In response to this:

/cherry-pick 18.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bogdando
Copy link
Contributor Author

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@bogdando: #1683 failed to apply on top of branch "18.0.0-proposed":

Applying: Add nodeset and job config for multicell
Using index info to reconstruct a base tree...
M	zuul.d/adoption.yaml
M	zuul.d/nodeset.yaml
Falling back to patching base and 3-way merge...
Auto-merging zuul.d/nodeset.yaml
CONFLICT (content): Merge conflict in zuul.d/nodeset.yaml
Auto-merging zuul.d/adoption.yaml
CONFLICT (content): Merge conflict in zuul.d/adoption.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add nodeset and job config for multicell

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants