Add data-plane-adoption job to the edpm-ansible zuul github-check layout #662

marios · 2024-05-28T15:47:10Z

This adds cifmw-data-plane-adoption-osp-17-to-extracted-crc to github-check.

https://issues.redhat.com/browse/OSPRH-7332

openshift-ci · 2024-05-28T15:47:16Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

softwarefactory-project-zuul · 2024-05-28T21:19:44Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1dfdefb19ab34d44bad29b33b34baead

slagle

I have the same comment here as I do on openstack-k8s-operators/dataplane-operator#902

openstack-k8s-operators/dataplane-operator#902 (review)

marios · 2024-05-30T09:33:25Z

I have the same comment here as I do on openstack-k8s-operators/dataplane-operator#902

openstack-k8s-operators/dataplane-operator#902 (review)

ack same as openstack-k8s-operators/dataplane-operator#902 (review)

let's add one job here explicitly and we can target it with files: for some of the roles we are most interested in for example

softwarefactory-project-zuul · 2024-05-30T13:47:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/74d8305caaed4ab1ad5330c11259aae0

marios · 2024-06-03T08:49:15Z

check-rdo

jpodivin

I think that if we are to run this at all it must be very selective. Furthermore, we must make sure that we aren't using this to test things which are already covered by molecule tests or other jobs.

Is there a role which absolutely requires this test?

marios · 2024-06-03T09:36:39Z

I think that if we are to run this at all it must be very selective. Furthermore, we must make sure that we aren't using this to test things which are already covered by molecule tests or other jobs.

Is there a role which absolutely requires this test?

there is a related conversation ongoing at openstack-k8s-operators/dataplane-operator#902 (comment) FYI

wrt to your question, this is the list of services we are deploying https://github.com/marios/data-plane-adoption/blob/ec0f395a8321dc4c3ced71b777102ad7dc9de1b2/tests/roles/dataplane_adoption/tasks/main.yaml#L256 (corresponding to the plays and roles from this repo being executed )

ciecierski · 2024-06-03T12:29:26Z

I think that if we are to run this at all it must be very selective. Furthermore, we must make sure that we aren't using this to test things which are already covered by molecule tests or other jobs.
Is there a role which absolutely requires this test?

there is a related conversation ongoing at openstack-k8s-operators/dataplane-operator#902 (comment) FYI

wrt to your question, this is the list of services we are deploying https://github.com/marios/data-plane-adoption/blob/ec0f395a8321dc4c3ced71b777102ad7dc9de1b2/tests/roles/dataplane_adoption/tasks/main.yaml#L256 (corresponding to the plays and roles from this repo being executed )

On top of that we have very specific adoption role: https://github.com/openstack-k8s-operators/edpm-ansible/tree/main/roles/edpm_pre_adoption_validation

softwarefactory-project-zuul · 2024-06-03T14:06:38Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/396f29b4806c48b68decc7562de4cb13

marios · 2024-06-05T10:22:08Z

zuul.d/projects.yaml

+        - cifmw-data-plane-adoption-osp-17-to-extracted-crc:
+            dependencies:
+              - openstack-k8s-operators-content-provider
+            # files based on https://github.com/marios/data-plane-adoption/blob/ec0f395a8321dc4c3ced71b777102ad7dc9de1b2/tests/roles/dataplane_adoption/tasks/main.yaml#L256


i updated the files: list based on yesterday's conversation.

As far as I can see these are the specific plays and roles we are consuming in this job cc @slagle @jpodivin @jistr @rebtoor @cescgina

Most of those I agree with. Not the plugins however. Those will be sufficiently tested indirectly through molecule tests for all roles. The molecule tests on running through github actions are already doing their part, triggering by plugin changes, I don't know about those running on Zuul.

On the other hand, you should include pre-adoption-validation role in the list.

ack fair enough I will update and remove plugins

and I'll add the pre-adoption-validation

softwarefactory-project-zuul · 2024-06-05T12:47:39Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/aa62ec29eb1a43b3a7f0159fd8a2a476

This adds cifmw-data-plane-adoption-osp-17-to-extracted-crc to github-check. https://issues.redhat.com/browse/OSPRH-7332

jpodivin · 2024-06-05T13:18:17Z

+2 from me. Unless there are further objections I think this is the best option we have.

softwarefactory-project-zuul · 2024-06-05T19:16:31Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ed39e15be1a441c3b0de3753308ceb12

marios · 2024-06-06T07:30:21Z

job is hitting https://issues.redhat.com/browse/OSPCIX-318

should be fixed today

https://logserver.rdoproject.org/62/662/52765469d665541b6f449f8f75f8fb06e93c321c/github-check/cifmw-data-plane-adoption-osp-17-to-extracted-crc/67523c6/controller/data-plane-adoption-tests-repo/data-plane-adoption/tests/logs/test_with_ceph_out_2024-06-05T14:38:11EDT.log

TASK [heat_adoption : deploy podified heat] ************************************
...
"The OpenStackControlPlane \"openstack\" is invalid: spec.databaseInstance: Forbidden: Changing the DatabaseInstance is not supported for existing deployments"], "stdout": "", "stdout_lines": []}

marios · 2024-06-07T07:54:48Z

check-rdo

adoption jobs were fixed/running green yesterday

softwarefactory-project-zuul · 2024-06-07T12:22:55Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fd374de8cce44ef2b140d5a13c8f99f5

marios · 2024-06-10T07:51:37Z

hold rechecks for now please the podified edpm jobs are hitting https://issues.redhat.com/browse/OSPCIX-328

https://logserver.rdoproject.org/62/662/52765469d665541b6f449f8f75f8fb06e93c321c/github-check/cifmw-crc-podified-edpm-baremetal/b247e00/job-output.txt

2024-06-07 06:24:57.582767 | controller | TASK [edpm_deploy_baremetal : Wait for OpenStackDataPlaneNodeSet to be deployed _raw_params=oc wait OpenStackDataPlaneNodeSet {{ cr_name }} --namespace={{ cifmw_install_yamls_defaults['NAMESPACE'] }} --for=condition=ready --timeout={{ cifmw_edpm_deploy_baremetal_wait_dataplane_timeout_mins }}m] ***
2024-06-07 06:24:57.582774 | controller | Friday 07 June 2024  06:24:57 -0400 (0:00:00.037)       0:44:10.831 ***********
2024-06-07 07:04:57.949268 | controller | fatal: [localhost]: FAILED! => changed=true

marios · 2024-06-11T07:40:49Z

check-rdo

edpm jobs should be fixed now (https://issues.redhat.com/browse/OSPCIX-328)

softwarefactory-project-zuul · 2024-06-11T12:13:50Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c5b157e9c4b3421aba66dc6095b57208

bogdando

check-rdo

adoption jobs were fixed/running green yesterday

lgtm

marios · 2024-06-11T14:45:03Z

and now blocked on new cix :/ https://issues.redhat.com/browse/OSPCIX-332

[edited to correct cix previously pointed to 328]

marios · 2024-06-12T08:49:45Z

please hold recheck until we have openstack-k8s-operators/data-plane-adoption#486 (and https://review.rdoproject.org/r/c/rdo-jobs/+/53425 merged) for OSPCIX-332

marios · 2024-06-12T14:33:52Z

check-rdo

softwarefactory-project-zuul · 2024-06-12T19:23:25Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/84a8a96cecb2453085865b9f8ce083ac

marios · 2024-06-13T06:46:00Z

check-rdo

should be green now after https://review.rdoproject.org/r/c/rdo-jobs/+/53473

marios · 2024-06-13T12:12:38Z

green run ready for merge please https://review.rdoproject.org/zuul/buildset/8aac08289be24cf1a2797dbcde434324

rebtoor · 2024-06-13T12:20:22Z

/approve

openshift-ci · 2024-06-13T12:20:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, cescgina, marios, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rebtoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marios requested a review from cescgina May 28, 2024 15:47

openshift-ci bot added the do-not-merge/work-in-progress label May 28, 2024

cescgina approved these changes May 29, 2024

View reviewed changes

openshift-ci bot assigned cescgina May 29, 2024

openshift-ci bot added the lgtm label May 29, 2024

slagle requested changes May 29, 2024

View reviewed changes

openshift-ci bot assigned slagle May 29, 2024

openshift-ci bot removed the lgtm label May 29, 2024

marios force-pushed the OSPRH-7332 branch from a2b48a8 to d8cb79c Compare May 30, 2024 10:04

marios changed the title ~~Add data-plane-adoption-pipeline to the zuul github-check layout~~ Add data-plane-adoption job to the edpm-ansible zuul github-check layout May 30, 2024

marios marked this pull request as ready for review May 31, 2024 08:24

openshift-ci bot removed the do-not-merge/work-in-progress label May 31, 2024

openshift-ci bot requested review from jpodivin and lewisdenny May 31, 2024 08:24

lewisdenny removed their request for review June 2, 2024 23:30

jpodivin reviewed Jun 3, 2024

View reviewed changes

marios force-pushed the OSPRH-7332 branch from d8cb79c to 6c63797 Compare June 5, 2024 09:14

marios commented Jun 5, 2024

View reviewed changes

Add data-plane-adoption job to the edpm-ansible zuul github-check layout

5276546

This adds cifmw-data-plane-adoption-osp-17-to-extracted-crc to github-check. https://issues.redhat.com/browse/OSPRH-7332

marios force-pushed the OSPRH-7332 branch from 6c63797 to 5276546 Compare June 5, 2024 13:09

marios mentioned this pull request Jun 6, 2024

Add data-plane-adoption job to the zuul dataplane operator github-check layout openstack-k8s-operators/dataplane-operator#902

Closed

marios requested a review from rebtoor June 7, 2024 09:28

bogdando approved these changes Jun 11, 2024

View reviewed changes

openshift-ci bot assigned bogdando Jun 11, 2024

openshift-ci bot added the lgtm label Jun 11, 2024

rebtoor approved these changes Jun 13, 2024

View reviewed changes

openshift-ci bot assigned rebtoor Jun 13, 2024

openshift-ci bot added the approved label Jun 13, 2024

openshift-merge-bot bot merged commit dff6a8a into openstack-k8s-operators:main Jun 13, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add data-plane-adoption job to the edpm-ansible zuul github-check layout #662

Add data-plane-adoption job to the edpm-ansible zuul github-check layout #662

marios commented May 28, 2024 •

edited

Loading

openshift-ci bot commented May 28, 2024

softwarefactory-project-zuul bot commented May 28, 2024

slagle left a comment

marios commented May 30, 2024

softwarefactory-project-zuul bot commented May 30, 2024

marios commented Jun 3, 2024

jpodivin left a comment

marios commented Jun 3, 2024

ciecierski commented Jun 3, 2024

softwarefactory-project-zuul bot commented Jun 3, 2024

marios Jun 5, 2024

jpodivin Jun 5, 2024

marios Jun 5, 2024

jpodivin Jun 5, 2024

softwarefactory-project-zuul bot commented Jun 5, 2024

jpodivin commented Jun 5, 2024

softwarefactory-project-zuul bot commented Jun 5, 2024

marios commented Jun 6, 2024

marios commented Jun 7, 2024

softwarefactory-project-zuul bot commented Jun 7, 2024

marios commented Jun 10, 2024

marios commented Jun 11, 2024

softwarefactory-project-zuul bot commented Jun 11, 2024

bogdando left a comment

marios commented Jun 11, 2024 •

edited

Loading

marios commented Jun 12, 2024 •

edited by openshift-ci bot

Loading

marios commented Jun 12, 2024

softwarefactory-project-zuul bot commented Jun 12, 2024

marios commented Jun 13, 2024

marios commented Jun 13, 2024

rebtoor commented Jun 13, 2024

openshift-ci bot commented Jun 13, 2024

Add data-plane-adoption job to the edpm-ansible zuul github-check layout #662

Add data-plane-adoption job to the edpm-ansible zuul github-check layout #662

Conversation

marios commented May 28, 2024 • edited Loading

openshift-ci bot commented May 28, 2024

softwarefactory-project-zuul bot commented May 28, 2024

slagle left a comment

Choose a reason for hiding this comment

marios commented May 30, 2024

softwarefactory-project-zuul bot commented May 30, 2024

marios commented Jun 3, 2024

jpodivin left a comment

Choose a reason for hiding this comment

marios commented Jun 3, 2024

ciecierski commented Jun 3, 2024

softwarefactory-project-zuul bot commented Jun 3, 2024

marios Jun 5, 2024

Choose a reason for hiding this comment

jpodivin Jun 5, 2024

Choose a reason for hiding this comment

marios Jun 5, 2024

Choose a reason for hiding this comment

jpodivin Jun 5, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 5, 2024

jpodivin commented Jun 5, 2024

softwarefactory-project-zuul bot commented Jun 5, 2024

marios commented Jun 6, 2024

marios commented Jun 7, 2024

softwarefactory-project-zuul bot commented Jun 7, 2024

marios commented Jun 10, 2024

marios commented Jun 11, 2024

softwarefactory-project-zuul bot commented Jun 11, 2024

bogdando left a comment

Choose a reason for hiding this comment

marios commented Jun 11, 2024 • edited Loading

marios commented Jun 12, 2024 • edited by openshift-ci bot Loading

marios commented Jun 12, 2024

softwarefactory-project-zuul bot commented Jun 12, 2024

marios commented Jun 13, 2024

marios commented Jun 13, 2024

rebtoor commented Jun 13, 2024

openshift-ci bot commented Jun 13, 2024

marios commented May 28, 2024 •

edited

Loading

marios commented Jun 11, 2024 •

edited

Loading

marios commented Jun 12, 2024 •

edited by openshift-ci bot

Loading