Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessibilityLabel property on icons in PINRules #1450

Conversation

ClaudeArs
Copy link
Contributor

Summary of Changes

Add accessibilityLabel property on icons in PINRules

Screenshots, videos, or gifs

Capture d’écran, le 2025-02-20 à 12 02 39

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@ClaudeArs ClaudeArs requested a review from a team as a code owner February 20, 2025 17:14
@jleach jleach changed the title Add accessibilityLabel property on icons in PINRules feat: add accessibilityLabel property on icons in PINRules Feb 20, 2025
@fc-santos fc-santos merged commit e9bd355 into openwallet-foundation:main Feb 20, 2025
8 checks passed
@fc-santos fc-santos deleted the fix/PINSecurity/accessibilityLabel-icon branch February 20, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants