Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessibilityLabel property on icons in PINRules #1450

Merged
merged 5 commits into from
Feb 20, 2025
Merged

feat: add accessibilityLabel property on icons in PINRules #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10d24b5
Add accessibilityLabel property on icons in PINRules
ClaudeArs Feb 20, 2025
d905013
Merge branch 'main' into fix/PINSecurity/accessibilityLabel-icon
ClaudeArs Feb 20, 2025
cb22247
Correct the label CheckIcon and ClearIcon in Index en
ClaudeArs Feb 20, 2025
95d9d12
Merge branch 'main' into fix/PINSecurity/accessibilityLabel-icon
ClaudeArs Feb 20, 2025
b3bdc68
Merge branch 'main' into fix/PINSecurity/accessibilityLabel-icon
ClaudeArs Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/legacy/core/App/localization/en/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ const translation = {
"PINOnlyContainDigitsValidation": "Must contain only digits.",
"PINTooShortValidation": "The PIN is not long enough.",
"PINTooLongValidation": "The PIN is too long enough.",
"CheckIcon": "Criteria met",
"ClearIcon": "Criteria not met",
},
"UserAuthenticationPIN": "User authentication PIN",
"PINTooShort": "PIN is too short",
Expand Down
2 changes: 2 additions & 0 deletions packages/legacy/core/App/localization/fr/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,8 @@ const translation = {
"PINOnlyContainDigitsValidation": "Doit contenir que des chiffres.",
"PINTooShortValidation": "Le NIP est trop court. Veuillez saisir le NIP à nouveau.",
"PINTooLongValidation": "Le NIP est trop long. Veuillez saisir le NIP à nouveau.",
"CheckIcon": "Critère respecté",
"ClearIcon": "Critère non-respecté",
},
"UserAuthenticationPIN": "NIP d'authentification de l'utilisateur",
"PINTooShort": "NIP trop court",
Expand Down
2 changes: 2 additions & 0 deletions packages/legacy/core/App/localization/pt-br/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ const translation = {
"PINOnlyContainDigitsValidation": "Deve conter apenas números.",
"PINTooShortValidation": "O PIN é curto demais.",
"PINTooLongValidation": "O PIN é longo demais.",
"CheckIcon": "Critério atendido",
"ClearIcon": "Critério não atendido",
},
"UserAuthenticationPIN": "PIN de autenticação do usuário",
"PINTooShort": "PIN é curto demais",
Expand Down
4 changes: 2 additions & 2 deletions packages/legacy/core/App/screens/PINCreate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,9 @@ const PINCreate: React.FC<PINCreateProps> = ({ setAuthenticated, explainedStatus
return (
<View style={{ flexDirection: 'row' }} key={index}>
{validation.isInvalid ? (
<Icon name="clear" size={iconSize} color={ColorPallet.notification.errorIcon} />
<Icon accessibilityLabel={t("PINCreate.Helper.ClearIcon")} name="clear" size={iconSize} color={ColorPallet.notification.errorIcon} />
) : (
<Icon name="check" size={iconSize} color={ColorPallet.notification.successIcon} />
<Icon accessibilityLabel={t("PINCreate.Helper.CheckIcon")} name="check" size={iconSize} color={ColorPallet.notification.successIcon} />
)}
<Text style={[TextTheme.normal, { paddingLeft: 4 }]}>
{t(`PINCreate.Helper.${validation.errorName}`)}
Expand Down