Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1370 1373 +3
Branches 237 239 +2
=========================================
+ Hits 1370 1373 +3 ☔ View full report in Codecov by Sentry. |
rgaudin
reviewed
Feb 13, 2024
Member
rgaudin
left a comment
rgaudin
left a comment
There was a problem hiding this comment.
Would make more sense to disable_metadata_checks IMO.
More clear (it's important but can be disabled) and more in line with recommendations.
WDYT?
Collaborator
Author
|
I hate naming things, and here I have no PoV, so I love your opinion 😉 |
rgaudin
reviewed
Feb 13, 2024
| compression: Optional[str] = None, | ||
| workaround_nocancel: Optional[bool] = True, # noqa: FBT002 | ||
| ignore_duplicates: Optional[bool] = False, # noqa: FBT002 | ||
| disable_metadata_checks: bool = True, # noqa: FBT001, FBT002 |
Member
There was a problem hiding this comment.
Should be False by default ; that's the point 😅
|
|
||
|
|
||
| def test_relax_metadata(tmp_path): | ||
| Creator(tmp_path, "", disable_metadata_checks=False).config_dev_metadata( |
Member
|
Well, you're up for a post-PR fix 🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #119
Changes
auto_metadata_checkparameter, which default toTruebut can be disabledOne question: I had to disable validation at two places, is it intentional?