Dynamic Dedicated FSS #154

MadalinaPatrichi · 2018-07-31T12:20:46Z

An FSS filesystem will be dynamically created to satisfy a Persistent Volume Claim. The created File System Storage is treated by Kubernetes as an NFSVolumeSource. This helps users as they do not need to create the filesystem or the MountTarget (if it does not exist) ahead of time.

The following cases are covered in the current implementation:

Mount Target ID is provided by the user in the storage class file. Subsequent PVCs referencing the storage claim will attach the newly created filesystem to the given Mount Target
Subnet ID is provided by the user in the storage class file. Subsequent PVCs referencing the storage claim will attach the newly created filesystem to a Mount Target dynamically created on the provided subnet.
None of the above mentioned parameters are provided in the storage class. Subsequent PVCs referencing the storage claim will attach the newly created filesystem to a Mount Target inside the given compartment chosen at random.

In addition to the implementation of the Dynamic Dedicated FSS implementation, an initial refactoring of the system tests has been included to simplify the testing process of the feature.

owainlewis · 2018-08-01T15:33:10Z

pkg/provisioner/filestorage/filestorage.go

+				NFS: &v1.NFSVolumeSource{
+					// Randomnly select IP address associated with the mount target to use for attachment
+					Server:   serverIP,
+					Path:     *common.String("/" + *response.FileSystem.Id),


*common.String isn't needed here

owainlewis · 2018-08-01T15:35:43Z

pkg/provisioner/filestorage/filestorage.go

+		Spec: v1.PersistentVolumeSpec{
+			PersistentVolumeReclaimPolicy: options.PersistentVolumeReclaimPolicy,
+			AccessModes:                   options.PVC.Spec.AccessModes,
+			//FIXME: fs storage doesn't enforce quota, capacity is meaningless here.


Can we propagate mountOptions here?

kind: StorageClass apiVersion: storage.k8s.io/v1 metadata: name: standard provisioner: kubernetes.io/aws-ebs parameters: type: gp2 reclaimPolicy: Retain mountOptions: - debug

Possibly, what are they useful for?

Maybe we should leave this for another commit? This is getting fairly big

owainlewis · 2018-08-01T15:36:23Z

pkg/provisioner/filestorage/filestorage_test.go

@@ -0,0 +1,41 @@
+// Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.


Thanks, bad copy/pasting on my part haha

Do all the files need to be updated?

prydie

Haven't reviewed the Python yet and will likely have more feedback on the Go next time around but overall great work 👍

prydie · 2018-08-01T10:00:50Z

Gopkg.toml

@@ -41,6 +41,6 @@
  name = "k8s.io/kubernetes"

 [[constraint]]
-  version = "v1.0.0"
+  version = "v1.5.0"


Version 2.1 of the SDK is out.

prydie · 2018-08-01T10:01:40Z

examples/example-claim-fss.template

@@ -0,0 +1,14 @@
+kind: PersistentVolumeClaim


Should not be in examples/

Should I create a separate folder for template files? I followed the model used by the block volume

They should live in a directory with the tests I think.

prydie · 2018-08-01T10:01:55Z

examples/example-pod-fss.template

@@ -0,0 +1,20 @@
+apiVersion: v1


Should not be in examples/

prydie · 2018-08-01T10:02:22Z

examples/example-storage-class-fss-mnt.template

+  name: oci-fss
+provisioner: oracle.com/oci-fss
+parameters:
+  mntTargetId: {{MNT_TARGET_OCID}}


Trailing \n

prydie · 2018-08-01T10:02:34Z

examples/example-storage-class-fss-mnt.template

@@ -0,0 +1,8 @@
+# Storage class with subnet OCID to create mount target on


Should not be in examples/

Moved to separate folder

prydie · 2018-08-02T10:44:44Z

pkg/provisioner/filestorage/filestorage_test.go

+
+func TestCreateVolumeWithFSS(t *testing.T) {
+	// test creating a volume on a file system storage
+	options := controller.VolumeOptions{PVName: "dummyVolumeOptions",


options := controller.VolumeOptions{ PVName: "dummyVolumeOptions", PVC: &v1.PersistentVolumeClaim{ ObjectMeta: metav1.ObjectMeta{}, }, }

prydie · 2018-08-02T10:45:16Z

pkg/provisioner/filestorage/filestorage_test.go

+	"github.com/oracle/oci-go-sdk/common"
+	"github.com/oracle/oci-go-sdk/identity"
+	"github.com/oracle/oci-volume-provisioner/pkg/helpers"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"


package ordering / separation

VS code does some ordering for me, but not completely. What are the conventions?

prydie · 2018-08-02T10:46:06Z

pkg/provisioner/filestorage/filestorage.go

+		MountTargetId: common.String(mountTargetID),
+	})
+	if err != nil {
+		glog.Errorf("Failed to retrieve mount point: %s", err)


glog.Errorf("Failed to retrieve mount point mountTargetId=%q: %v", mountTargetID, err)

prydie · 2018-08-02T10:46:23Z

pkg/provisioner/filestorage/filestorage.go

+	"github.com/oracle/oci-go-sdk/common"
+	"github.com/oracle/oci-go-sdk/core"
+	"github.com/oracle/oci-go-sdk/filestorage"
+	"github.com/oracle/oci-go-sdk/identity"


Import ordering / grouping

prydie · 2018-08-02T10:47:06Z

pkg/provisioner/filestorage/filestorage.go

+			Path:         common.String("/" + *response.FileSystem.Id),
+		},
+	})
+


owainlewis · 2018-08-03T13:18:22Z

Makefile

-DOCKER_REGISTRY_TENANCY ?= oracle
-DOCKER_REGISTRY_USERNAME ?= oracle
+DOCKER_REGISTRY_TENANCY ?= spinnaker
+DOCKER_REGISTRY_USERNAME ?= spinnaker/ioana-madalina.patrichi@oracle.com


Need to revert this

Thanks for spotting this

owainlewis · 2018-08-03T13:21:21Z

examples/example-claim-fss.yaml

+  storageClassName: "oci-fss"
+  selector:
+    matchLabels:
+      oci-availability-domain: "PHX-AD-1"


This is the older deprecated label. Can use failure-domain.beta.kubernetes.io/zone: "PHX-AD-1" instead.

owainlewis · 2018-08-03T13:32:35Z

pkg/provisioner/filestorage/filestorage.go

+	}
+	serverIP := ""
+	if len(mntTargetResp.PrivateIpIds) != 0 {
+		privateIPID := mntTargetResp.PrivateIpIds[rand.Int()%len(mntTargetResp.PrivateIpIds)]


I'd add a space for readability

rand.Int() % len(mntTargetResp.PrivateIpIds)

MadalinaPatrichi · 2018-08-10T10:02:10Z

Gopkg.toml

@@ -43,4 +43,3 @@
 [[constraint]]
  version = "v1.6.0"
  name = "github.com/oracle/oci-go-sdk"
-


owainlewis · 2018-08-13T15:03:18Z

pkg/provisioner/core/provisioner.go

 	"github.com/oracle/oci-volume-provisioner/pkg/provisioner/plugin"
 )

 const (
+	// ProvisionerNameBlock name to deploy block provisioner by


ProvisionerNameBlock is the name of the OCI block volume provisioner

owainlewis · 2018-08-13T15:03:52Z

pkg/provisioner/core/provisioner.go

 	"github.com/oracle/oci-volume-provisioner/pkg/provisioner/plugin"
 )

 const (
+	// ProvisionerNameBlock name to deploy block provisioner by
+	ProvisionerNameBlock = "oracle.com/oci"
+	// ProvisionerNameFss name to deploy block provisioner by


ProvisionerNameFss is the name of the OCI FSS dedicated storage provisioner

owainlewis · 2018-08-13T15:18:42Z

pkg/provisioner/filestorage/filestorage.go

+var _ plugin.ProvisionerPlugin = &filesystemProvisioner{}
+
+// NewFilesystemProvisioner creates a new file system provisioner that creates
+// filsystems using OCI file system service.


filsystems using OCI file system service. => filesystems using OCI File Storage Service.

owainlewis · 2018-08-13T15:21:17Z

pkg/provisioner/filestorage/filestorage.go

+}
+
+func getOrCreateMountTarget(ctx context.Context, availabilityDomain *string, subnetID string, compartmentID string, fileStorageClient client.FileStorage) (id *filestorage.MountTarget, err error) {
+	// Check if there there already is a mount target in the existing compartment


Typo Check if there is already a mount target in the existing compartment

owainlewis · 2018-08-13T15:23:04Z

pkg/provisioner/filestorage/filestorage.go

+		},
+	})
+	if err != nil {
+		glog.Errorf("Failed to create a file system options:%#v, %s", options, err)


glog.Errorf("Failed to create a file system. Options: %#v, %s", options, err)

prydie · 2018-08-13T14:47:26Z

.gitignore

@@ -5,3 +5,6 @@ env.sh
 *.log
 test/system/venv/
 test/system/run-test-image.yaml*
+examples/*.yaml


Seems a strange .gitignore rule

I'll modify it to point to the templates folder. If the test are run locally and interrupted half way through, the generated yaml files are not being deleted

prydie · 2018-08-13T15:02:23Z

cmd/main.go

@@ -92,6 +91,14 @@ func main() {
 		glog.Fatal("env variable NODE_NAME must be set so that this provisioner can identify itself")
 	}

+	// Decides what type of provider to deploy, either block or fss
+	provisionerType := os.Getenv("PROVISIONER_TYPE")


I thought we decided that we were going to run both provisioners by default and allow disabling specific provisioners behind a command line flag (see: here).

I spoke to @owainlewis and he was more in favour of having separate provisioners

Let's discuss offline then

prydie · 2018-08-13T15:03:18Z

pkg/helpers/mock_interfaces.go

+	"github.com/oracle/oci-go-sdk/core"
+	"github.com/oracle/oci-go-sdk/filestorage"
+	"github.com/oracle/oci-go-sdk/identity"
+	"github.com/oracle/oci-volume-provisioner/pkg/oci/client"


Import grouping

prydie · 2018-08-13T15:05:27Z

pkg/helpers/mock_interfaces.go

+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package helpers


Packages like "util" and "helpers" are generally to be avoided where possible. Generally mocks should be colocated with the packages that they are mocking which should remove the need for this pkg.

I wanted to reuse it across provisioners unit tests. I moved it within the provisioners package and removed helpers

prydie · 2018-08-13T15:07:31Z

pkg/provisioner/core/provisioner.go

 	"github.com/oracle/oci-volume-provisioner/pkg/provisioner/plugin"
 )

 const (
+	// ProvisionerNameBlock name to deploy block provisioner by
+	ProvisionerNameBlock = "oracle.com/oci"


Block should be the default method of provisioning, however, we should update the name and explicitly implement defaulting.

prydie · 2018-08-13T15:23:38Z

pkg/provisioner/filestorage/filestorage_test.go

+	"github.com/oracle/oci-volume-provisioner/pkg/helpers"
+)
+
+func TestCreateVolumeWithFSS(t *testing.T) {


Need more unit tests

prydie · 2018-08-13T15:23:55Z

pkg/provisioner/filestorage/filestorage_test.go

+	if err != nil {
+		t.Fatalf("Failed to provision volume from block storage: %v", err)
+	}
+


prydie · 2018-08-13T15:25:42Z

pkg/provisioner/filestorage/filestorage.go

+}
+
+// getMountTargetFromID retrieves mountTarget from given mountTargetID
+func getMountTargetFromID(ctx context.Context, mountTargetID string, fileStorageClient client.FileStorage) (*filestorage.MountTarget, error) {


Rather than pass in the client I'd make this a private method on the struct

prydie · 2018-08-13T15:27:24Z

pkg/provisioner/filestorage/filestorage.go

+	glog.Infof("Deleting export for filesystemID %v", filesystemID)
+	if _, err := filesystem.client.FileStorage().DeleteExport(ctx, filestorage.DeleteExportRequest{
+		ExportId: &exportID,
+	}); err != nil {


Need to check if the error is that it doesn't exist and continue if that's the case. Otherwise Delete() isn't idempotent.

prydie · 2018-08-13T15:28:05Z

pkg/provisioner/filestorage/filestorage.go

+	_, err := filesystem.client.FileStorage().DeleteFileSystem(ctx, filestorage.DeleteFileSystemRequest{
+		FileSystemId: &filesystemID,
+	})
+	return err


Same as above re checking if it's a does not exist error.

prydie · 2018-08-13T17:06:04Z

pkg/provisioner/filestorage/filestorage.go

+	glog.Infof("Deleting export for filesystemID %v", filesystemID)
+	if _, err := fsp.client.FileStorage().DeleteExport(ctx, filestorage.DeleteExportRequest{
+		ExportId: &exportID,
+	}); err != nil {


Needs check for not found error (see: here in ccm)

prydie · 2018-08-13T17:09:26Z

test/system/backupVolSystemTest.py

@@ -0,0 +1,134 @@
+#!/usr/bin/env python


backupVolSystemTest.py -> backup_vol_system_test.py

prydie · 2018-08-13T17:09:58Z

test/system/blockSystemTest.py

@@ -0,0 +1,54 @@
+#!/usr/bin/env python


blockSystemTest.py -> block_system_test.py

prydie · 2018-08-13T17:10:36Z

test/system/canaryMetrics.py

@@ -0,0 +1,48 @@
+#!/usr/bin/env python


canaryMetrics.py -> canary_metrics.py

prydie · 2018-08-13T17:11:05Z

test/system/fssSystemTest.py

@@ -0,0 +1,88 @@
+#!/usr/bin/env python


fssSystemTest.py -> fss_system_test.py

This goes against everything I believe in, but, okay ... haha

https://www.python.org/dev/peps/pep-0008/#package-and-module-name 😉

prydie · 2018-08-13T17:29:29Z

pkg/provisioner/filestorage/filestorage.go

+	filesystemID, ok := volume.Annotations[ociVolumeID]
+	if !ok {
+		return fmt.Errorf("%q annotation not found on PV", ociVolumeID)
+	}


Break up w/ \n

prydie · 2018-08-13T17:30:09Z

pkg/provisioner/filestorage/filestorage.go

+	if !ok {
+		return fmt.Errorf("%q annotation not found on PV", ociVolumeID)
+	}
+	ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout())


You're sharing the timeout across multiple requests here which is probably not what you want.

prydie · 2018-08-13T17:30:42Z

pkg/provisioner/filestorage/filestorage.go

+}
+
+func (fsp *filesystemProvisioner) Provision(options controller.VolumeOptions, ad *identity.AvailabilityDomain) (*v1.PersistentVolume, error) {
+	ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout())


You're sharing the timeout here across multiple requests which probably isn't what you want.

prydie · 2018-08-13T17:32:43Z

pkg/provisioner/filestorage/filestorage.go

+		return nil, fmt.Errorf("failed to find server IDs associated with the mount target")
+	}
+	privateIPID := target.PrivateIpIds[rand.Int()%len(target.PrivateIpIds)]
+	virtualNetworkClient := fsp.client.VirtualNetwork()


Maybe instead of assigning a local variable rename fsp.client.VirtualNetwork() to fsp.client.VCN() and just use directly?

prydie · 2018-08-13T17:33:45Z

pkg/provisioner/filestorage/filestorage.go

+	ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout())
+	defer cancel()
+
+	fileStorageClient := fsp.client.FileStorage()


Instead of assigning to a local variable maybe rename to fsp.client.FSS() and use directly?

The fact that we're instantiating so many FSS clients should not have a huge effect on memory usage or anything else, right?

Yeah, fsp.client.FSS() should just return a pointer to an already initialised client so will be nice and cheap.

-Correctly mock out FileStorageClient -Start separate volume provisioner for fss case _ start of impl of list mount target -Add check for listing mount targets + add .yaml files to gitignore -Remove reference to non existing pvc and update the oci provisioner fss config

-Retrieve pirvate ip for mount target and fixed system tests -Ignore linting mock_interfaces -Fix for config file for creating rc with volume claim

prydie

Nearly there 👍

prydie · 2018-08-14T12:48:55Z

pkg/provisioner/filestorage/filestorage.go

+	return mtResponse.Items, nil
+}
+
+func (fsp *filesystemProvisioner) getOrCreateMountTarget(ad *string, subnetID *string, compartmentID *string) (*filestorage.MountTarget, error) {


Don't pass pointers to strings around; grab their values from responses and then use those as we don't want to spread the SDKs anti-patterns.

prydie · 2018-08-15T11:12:37Z

pkg/oci/client/client.go

 // ProvisionerClient is passed to all sub clients to provision a volume
 type ProvisionerClient interface {
 	BlockStorage() BlockStorage
 	Identity() Identity
+	FSS() FSS
+	VCN() VCN


prydie · 2018-08-15T11:14:28Z

pkg/provisioner/filestorage/filestorage.go

+	}
+	mtResponse.Items = append(mtResponse.Items, resp.Items...)
+	if resp.OpcNextPage != nil {
+		return fsp.listAllMountTargets(ad, mtResponse)


I think a for-loop based pagination implementation is a bit cleaner (see: here in ccm).

prydie · 2018-08-15T11:16:05Z

pkg/provisioner/filestorage/filestorage.go

+	return mtResponse.Items, nil
+}
+
+func (fsp *filesystemProvisioner) getOrCreateMountTarget(mtID *string, ad *string, subnetID *string) (*filestorage.MountTarget, error) {


Don't pass around pointers to primitives. We don't want the sdk's anti-patterns to seep too far into our code.

prydie · 2018-08-15T11:30:50Z

pkg/provisioner/filestorage/filestorage.go

+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package filestorage


I'd probably name the package fss as multi-word names aren't encouraged in go and missing out the "system" somewhat mischaracterises the package.

prydie · 2018-08-15T11:45:02Z

pkg/provisioner/filestorage/filestorage.go

+}
+
+// getMountTargetFromID retrieves mountTarget from given mountTargetID
+func (fsp *filesystemProvisioner) getMountTargetFromID(mountTargetID *string) (*filestorage.MountTarget, error) {


Don't pass around pointers to primitives

prydie · 2018-08-15T11:46:02Z

pkg/provisioner/filestorage/filestorage.go

+		// Mount target already specified in the configuration file, find it in the list of mount targets
+		return fsp.getMountTargetFromID(mtID)
+	}
+	ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout())


This is redundant

prydie · 2018-08-15T11:46:22Z

pkg/provisioner/filestorage/filestorage.go

+	return &resp.MountTarget, nil
+}
+
+func (fsp *filesystemProvisioner) Provision(options controller.VolumeOptions, ad *identity.AvailabilityDomain) (*v1.PersistentVolume, error) {


func (fsp *filesystemProvisioner) Provision(options controller.VolumeOptions, ad *identity.AvailabilityDomain) (*v1.PersistentVolume, error) { // Create the FileSystem. var fsID string { ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout()) defer cancel() resp, err := fsp.client.FSS().CreateFileSystem(ctx, filestorage.CreateFileSystemRequest{ CreateFileSystemDetails: filestorage.CreateFileSystemDetails{ AvailabilityDomain: ad.Name, CompartmentId: common.String(fsp.client.CompartmentOCID()), DisplayName: common.String(fmt.Sprintf("%s%s", os.Getenv(volumePrefixEnvVarName), options.PVC.Name)), }, }) if err != nil { glog.Errorf("Failed to create a file system options=%#v: %v", options, err) return nil, err } fsID = *resp.FileSystem.Id } target, err := fsp.getOrCreateMountTarget(common.String(options.Parameters[mntTargetID]), ad.Name, common.String(options.Parameters[subnetID])) if err != nil { glog.Errorf("Failed to retrieve mount target: %s", err) return nil, err } glog.V(6).Infof("Creating export set") // Creaete the Export. var exportSetID string { ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout()) defer cancel() resp, err := fsp.client.FSS().CreateExport(ctx, filestorage.CreateExportRequest{ CreateExportDetails: filestorage.CreateExportDetails{ ExportSetId: target.ExportSetId, FileSystemId: &fsID, Path: common.String("/" + fsID), }, }) if err != nil { glog.Errorf("Failed to create export: %v", err) return nil, err } exportSetID = *resp.Export.Id } if len(target.PrivateIpIds) == 0 { glog.Errorf("Failed to find server IDs associated with the Mount Target (OCID %q) to provision a persistent volume", *target.Id) return nil, errors.Errorf("failed to find server IDs associated with the Mount Target with OCID %q", *target.Id) } // Get PrivateIP. var serverIP string { ctx, cancel := context.WithTimeout(fsp.client.Context(), fsp.client.Timeout()) defer cancel() id := target.PrivateIpIds[rand.Int()%len(target.PrivateIpIds)] getPrivateIPResponse, err := fsp.client.VCN().GetPrivateIp(ctx, core.GetPrivateIpRequest{ PrivateIpId: &id, }) if err != nil { glog.Errorf("Failed to retrieve IP address for mount target privateIpID=%q: %v", id, err) return nil, err } serverIP = *getPrivateIPResponse.PrivateIp.IpAddress } glog.Infof("Creating persistent volume on mount target with private IP address %q", serverIP) return &v1.PersistentVolume{ ObjectMeta: metav1.ObjectMeta{ Name: fsID, Annotations: map[string]string{ ociVolumeID: fsID, ociExportID: exportSetID, }, Labels: map[string]string{}, }, Spec: v1.PersistentVolumeSpec{ PersistentVolumeReclaimPolicy: options.PersistentVolumeReclaimPolicy, AccessModes: options.PVC.Spec.AccessModes, //FIXME: fs storage doesn't enforce quota, capacity is meaningless here. Capacity: v1.ResourceList{ v1.ResourceName(v1.ResourceStorage): options.PVC.Spec.Resources.Requests[v1.ResourceName(v1.ResourceStorage)], }, PersistentVolumeSource: v1.PersistentVolumeSource{ NFS: &v1.NFSVolumeSource{ // Randomnly select IP address associated with the mount target to use for attachment Server: serverIP, Path: "/" + fsID, ReadOnly: false, }, }, }, }, nil }

Thanks a lot, looks much better!

prydie · 2018-08-15T11:47:12Z

pkg/provisioner/filestorage/filestorage.go

+func (fsp *filesystemProvisioner) Delete(volume *v1.PersistentVolume) error {
+	exportID, ok := volume.Annotations[ociExportID]
+	if !ok {
+		return fmt.Errorf("%q annotation not found on PV", ociExportID)


Use pkg/errors's errors.Errorf so we retain the stacktrace.

prydie · 2018-08-15T11:47:16Z

pkg/provisioner/filestorage/filestorage.go

+
+	filesystemID, ok := volume.Annotations[ociVolumeID]
+	if !ok {
+		return fmt.Errorf("%q annotation not found on PV", ociVolumeID)


Use pkg/errors's errors.Errorf so we retain the stacktrace.

-Added unit test for mount target ocid specified -Rebased from master and refactored provisioner deployment

…ild (#194) Fixes oracle#154

MadalinaPatrichi requested a review from owainlewis July 31, 2018 12:20

owainlewis reviewed Aug 1, 2018

View reviewed changes

MadalinaPatrichi requested a review from bdourallawzi August 2, 2018 08:01

prydie suggested changes Aug 2, 2018

View reviewed changes

owainlewis reviewed Aug 3, 2018

View reviewed changes

MadalinaPatrichi force-pushed the mp/fileStorageNew branch 4 times, most recently from fcdbcee to c267b61 Compare August 10, 2018 09:52

MadalinaPatrichi commented Aug 10, 2018

View reviewed changes

Gopkg.toml Outdated

@@ -43,4 +43,3 @@

[[constraint]]

version = "v1.6.0"

name = "github.com/oracle/oci-go-sdk"

Copy link

Member Author

MadalinaPatrichi Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MadalinaPatrichi force-pushed the mp/fileStorageNew branch 10 times, most recently from df5ec1d to e687e3e Compare August 13, 2018 14:04

MadalinaPatrichi changed the title ~~[WIP] Dedicated FSS~~ Dedicated FSS Aug 13, 2018

MadalinaPatrichi force-pushed the mp/fileStorageNew branch from e687e3e to 1c78f0c Compare August 13, 2018 14:20

oracle deleted a comment from MadalinaPatrichi Aug 13, 2018

MadalinaPatrichi force-pushed the mp/fileStorageNew branch from 1c78f0c to 2bf4d49 Compare August 13, 2018 14:52

oracle deleted a comment from MadalinaPatrichi Aug 13, 2018

owainlewis reviewed Aug 13, 2018

View reviewed changes

prydie suggested changes Aug 13, 2018

View reviewed changes

MadalinaPatrichi force-pushed the mp/fileStorageNew branch from 2bf4d49 to eca238b Compare August 13, 2018 16:34

oracle deleted a comment from MadalinaPatrichi Aug 13, 2018

prydie suggested changes Aug 13, 2018

View reviewed changes

MadalinaPatrichi force-pushed the mp/fileStorageNew branch 4 times, most recently from 2b5f553 to e5437aa Compare August 15, 2018 09:09

MadalinaPatrichi added 4 commits August 15, 2018 11:31

Specify kubeconfig when running terraform actions

c533b11

FSS one-to-one implementation

df40f79

Added support for export deletion

faf1247

-Retrieve pirvate ip for mount target and fixed system tests -Ignore linting mock_interfaces -Fix for config file for creating rc with volume claim

MadalinaPatrichi force-pushed the mp/fileStorageNew branch from e5437aa to 3073096 Compare August 15, 2018 10:32

MadalinaPatrichi changed the title ~~Dedicated FSS~~ Dynamic Dedicated FSS Aug 15, 2018

prydie suggested changes Aug 15, 2018

View reviewed changes

MadalinaPatrichi force-pushed the mp/fileStorageNew branch from 3073096 to 7cc270e Compare August 15, 2018 13:12

Refactored system unit tests

8fa9e37

-Added unit test for mount target ocid specified -Rebased from master and refactored provisioner deployment

MadalinaPatrichi force-pushed the mp/fileStorageNew branch from 7cc270e to 8fa9e37 Compare August 15, 2018 13:23

owainlewis added the enhancement label Aug 15, 2018

MadalinaPatrichi merged commit 00cc911 into master Aug 15, 2018

MadalinaPatrichi mentioned this pull request Aug 17, 2018

Don't rely on storage class names to dispatch custom logic #131

Closed

prydie deleted the mp/fileStorageNew branch September 4, 2018 10:35

rjtsdl pushed a commit to rjtsdl/oci-volume-provisioner that referenced this pull request Dec 20, 2018

Check a version hasn't been pushed/released already during Wercker bu…

aa07329

…ild (#194) Fixes oracle#154

		@@ -0,0 +1,41 @@
		// Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.

		@@ -0,0 +1,8 @@
		# Storage class with subnet OCID to create mount target on

Dynamic Dedicated FSS #154

Dynamic Dedicated FSS #154

Conversation

MadalinaPatrichi commented Jul 31, 2018 • edited by owainlewis Loading

owainlewis Aug 1, 2018 • edited Loading

Choose a reason for hiding this comment

owainlewis Aug 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prydie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owainlewis Aug 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owainlewis Aug 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MadalinaPatrichi Aug 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MadalinaPatrichi commented Jul 31, 2018 •

edited by owainlewis

Loading

owainlewis Aug 1, 2018 •

edited

Loading

owainlewis Aug 1, 2018 •

edited

Loading

owainlewis Aug 3, 2018 •

edited

Loading

owainlewis Aug 13, 2018 •

edited

Loading

MadalinaPatrichi Aug 13, 2018 •

edited

Loading