Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-mgs-metrics flake fix: Parse dropshot error response #7592

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

jgallagher
Copy link
Contributor

Fixes #7363.

I was able to reproduce this locally by making MGS sleep between starting its Oximeter server and starting to collect metrics from SPs:

+++ b/gateway/src/metrics.rs
@@ -427,6 +427,7 @@ async fn start_pollers(
     .await
     .context("we should never return a fatal error here")?;

+    tokio::time::sleep(std::time::Duration::from_secs(20)).await;
     slog::info!(
         &log,
         "starting to poll SP sensor data every {SP_POLL_INTERVAL:?}"

With that sleep injected and the changes in this PR, the test takes ~30 seconds instead of ~10 seconds, but still passes.

@jgallagher jgallagher requested review from iliana and hawkw February 21, 2025 21:24
@jgallagher jgallagher enabled auto-merge (squash) February 21, 2025 21:57
@jgallagher jgallagher merged commit e20649a into main Feb 22, 2025
16 checks passed
@jgallagher jgallagher deleted the john/fix-test-mgs-metrics branch February 22, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test failed in CI: test_mgs_metrics, missing field tables
2 participants