Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-mgs-metrics flake fix: Parse dropshot error response #7592

Merged
merged 1 commit into from
Feb 22, 2025
Merged

test-mgs-metrics flake fix: Parse dropshot error response #7592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions nexus/tests/integration_tests/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,15 @@ pub async fn execute_timeseries_query(

// Check for a timeseries-not-found error specifically.
if rsp.status.is_client_error() {
let text = std::str::from_utf8(&rsp.body)
.expect("Timeseries query response body should be UTF-8");
if text.starts_with("Timeseries not found for: ") {
let err =
rsp.parsed_body::<HttpErrorResponseBody>().unwrap_or_else(|e| {
panic!(
"could not parse body as `HttpErrorResponseBody`: {e:?}\n\
query: {query}\nresponse: {rsp:#?}",
)
});

if err.message.starts_with("Timeseries not found for: ") {
return None;
}
}
Expand Down
Loading