#34640: CLN: remove 'private_key' and 'verbose' from gbq #34654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since those two kwargs weren't removed along with #30200 , also cc @jbrockmendel , just in case this was made on purpose by him. |
tswast
approved these changes
Jun 9, 2020
jreback
requested changes
Jun 9, 2020
5 tasks
jreback
requested changes
Jun 15, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -379,7 +379,7 @@ Other API changes | |||
| - ``loc`` lookups with an object-dtype :class:`Index` and an integer key will now raise ``KeyError`` instead of ``TypeError`` when key is missing (:issue:`31905`) | |||
| - Using a :func:`pandas.api.indexers.BaseIndexer` with ``count``, ``min``, ``max``, ``median``, ``skew``, ``cov``, ``corr`` will now return correct results for any monotonic :func:`pandas.api.indexers.BaseIndexer` descendant (:issue:`32865`) | |||
| - Added a :func:`pandas.api.indexers.FixedForwardWindowIndexer` class to support forward-looking windows during ``rolling`` operations. | |||
| - | |||
| - Removed ``private_key`` and ``verbose`` from gbq (:issue:`34654`) | |||
There was a problem hiding this comment.
can you co-locate this with the other issue where we removed a keyword from gbq; also pls use the references to read_gbq (see the other issue)
|
hi, you need to rebase and resolve the conflicts in the two files listed below, otherwise, your commit won't get through and make CI run. |
|
@parkdj1 - Thanks for the PR, can you address the test failures and fix up the commits seems to be a few unrelated changes. |
|
@parkdj1 is this still active? Ref my comments above: #34654 (comment) Also whatsnew will be 1.2 now. Thanks |
jreback
requested changes
Sep 13, 2020
jreback
approved these changes
Sep 24, 2020
|
thanks @parkdj1 |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
private_keyandverbosefrom gbq #34640black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffHello, I am new to contributing to open source, so thank you in advance for any corrections and suggestions. Please let me know if I need to do anything else for this ticket!
I removed the code containing both 'private_key' and 'verbose' from the gbq.py file.